On Oct 8, 10:49 am, thomas hartman <thomashartm...@googlemail.com>
wrote:
> so, you might want different patch-send emails for different repos you
> control?
Haha, I'm being an archetypical customer am I not? :-)
What I'd like right now:
I'd like the email address I signed up to patch-tag with in the
_darcs/prefs/email on all my repos, to make it easier for contributors
to send in patches. I'd like this for all my existing repos, and also
to happen automatically on creation of new repos.
What I think would be nice to have in the longer term:
A way of controlling the address that goes into the _darcs/prefs/
email on a per-repo basis, e.g. as part of the per-repo-admin UI on
the site. The defaul email address would be the one used to sign up
to patch-tag.
> Hm... is the desired behavior that your primary patch-tag email (ie
> the email you signed up with) gets put into _darcs/prefs/email?
> Is that something everyone wants?
> On Oct 8, 12:57 am, Magnus Therning <mag...@therning.org> wrote:
>> Is there some way of getting my email address into _darcs/prefs/email
>> in patch-tag.com repos?
>> It would help contributors with using "darcs send".
At the request of users, I started to implement a behavior in
patch-tag where the _darcs/prefs/email gets set to the primary email
of the user that owns the repo.
However, I don't think this will be useful, because when I darcs get a
repo with the _darcs/prefs/email file set, the fetched repo is missing
that file.
Am I missing something?
root@ubuntu:/tmp# cat /jail/privaterepos/mae/mae-testproject/_darcs/prefs/email
m...@gmail.com
root@ubuntu:/tmp# darcs get /jail/privaterepos/mae/mae-testproject
Copying patches, to get lazy repository hit ctrl-C...
Finished getting.
root@ubuntu:/tmp# ls mae-testproject/_darcs/prefs/
binaries boring defaultrepo motd repos sources
> On Oct 8, 2009, at 5:07, thomas hartman
> <thomashartm...@googlemail.com> wrote:
>> Hm... is the desired behavior that your primary patch-tag email (ie
>> the email you signed up with) gets put into _darcs/prefs/email?
>> Is that something everyone wants?
>> On Oct 8, 12:57 am, Magnus Therning <mag...@therning.org> wrote:
>>> Is there some way of getting my email address into _darcs/prefs/email
>>> in patch-tag.com repos?
>>> It would help contributors with using "darcs send".
quoth Max Batcher on the darcs users mailing list: "Darcs send checks
"upstream" in order to determine which patches need to be sent, just
like darcs push, and just like darcs push it defaults this check to
_darcs/prefs/defaultrepo. Darcs doesn't copy the _darcs/prefs/email,
it simply expects to be provided a remote repo."
So, it seems creating the _darcs/prefs/email won't do anything useful.
However, I did try to get patch-tag to do its bit anyway, by improving
the "repo commands" section to suggest what users can do to send
patches to the repo owner, eg:
> At the request of users, I started to implement a behavior in
> patch-tag where the _darcs/prefs/email gets set to the primary email
> of the user that owns the repo.
> However, I don't think this will be useful, because when I darcs get a
> repo with the _darcs/prefs/email file set, the fetched repo is missing
> that file.
> Am I missing something?
> root@ubuntu:/tmp# cat /jail/privaterepos/mae/mae-testproject/_darcs/prefs/email
> m...@gmail.com
> root@ubuntu:/tmp# darcs get /jail/privaterepos/mae/mae-testproject
> Copying patches, to get lazy repository hit ctrl-C...
> Finished getting.
> root@ubuntu:/tmp# ls mae-testproject/_darcs/prefs/
> binaries boring defaultrepo motd repos sources
> > On Oct 8, 2009, at 5:07, thomas hartman
> > <thomashartm...@googlemail.com> wrote:
> >> Hm... is the desired behavior that your primary patch-tag email (ie
> >> the email you signed up with) gets put into _darcs/prefs/email?
> >> Is that something everyone wants?
> >> On Oct 8, 12:57 am, Magnus Therning <mag...@therning.org> wrote:
> >>> Is there some way of getting my email address into _darcs/prefs/email
> >>> in patch-tag.com repos?
> >>> It would help contributors with using "darcs send".
On Sat, Oct 10, 2009 at 22:19:12 -0700, thomas hartman wrote: > quoth Max Batcher on the darcs users mailing list: "Darcs send checks > "upstream" in order to determine which patches need to be sent, just > like darcs push, and just like darcs push it defaults this check to > _darcs/prefs/defaultrepo. Darcs doesn't copy the _darcs/prefs/email, > it simply expects to be provided a remote repo."
> So, it seems creating the _darcs/prefs/email won't do anything useful.
I'm sure you saw Trent's explanation on the darcs-users mailing list, but just in case: darcs uses the *remote* _darcs/prefs/email to determine where to send the email to, so it would be very useful indeed.
I realise that our use of _darcs/prefs is very confusing because we use the same directory for three very different things:
remote prefs: - motd <-- this could also be useful for patch-taggers - email local prefs: - author - defaultrepo - defaults - sources - boring - binaries internal metadata: - prefs <-- used by setpref
Darcs users/hackers : perhaps a good thing would be for future darcs to have a _darcs/localprefs to avoid this confusion. I don't think there is much we can do about _darcs/prefs/prefs, on the other hand.
> On Sat, Oct 10, 2009 at 22:19:12 -0700, thomas hartman wrote:
> > quoth Max Batcher on the darcs users mailing list: "Darcs send checks
> > "upstream" in order to determine which patches need to be sent, just
> > like darcs push, and just like darcs push it defaults this check to
> > _darcs/prefs/defaultrepo. Darcs doesn't copy the _darcs/prefs/email,
> > it simply expects to be provided a remote repo."
> > So, it seems creating the _darcs/prefs/email won't do anything useful.
> I'm sure you saw Trent's explanation on the darcs-users mailing list,
> but just in case: darcs uses the *remote* _darcs/prefs/email to
> determine where to send the email to, so it would be very useful indeed.
> I realise that our use of _darcs/prefs is very confusing because we
> use the same directory for three very different things:
> remote prefs:
> - motd <-- this could also be useful for patch-taggers
> - email
> local prefs:
> - author
> - defaultrepo
> - defaults
> - sources
> - boring
> - binaries
> internal metadata:
> - prefs <-- used by setpref
> Darcs users/hackers : perhaps a good thing would be for future darcs to
> have a _darcs/localprefs to avoid this confusion. I don't think there
> is much we can do about _darcs/prefs/prefs, on the other hand.
On Sun, Oct 11, 2009 at 7:27 AM, Eric Kow <ko...@darcs.net> wrote: > On Sun, Oct 11, 2009 at 04:54:38 -0400, Max Battcher wrote: >> On 10/11/2009 4:02, Eric Kow wrote: >> >Also, I should correct one of the errors in my earlier message: >> >_darcs/prefs/sources should be treated as internal Darcs metadata, >> >not a local pref
>> I would say that's a fine line distinction right there-- I've had to >> edit _darcs/prefs/sources for various reasons and I could see >> someone manually pruning it as appropriate...
> I we need to think a bit more carefully about this, especially why we > make these distinctions. I seem to be confusing myself at least!
> The reason why I first said it was local information was because as you > said above, you sometimes edit it as appropriate.
> The reason I later backtracked and said it was internal metadata was > because Darcs manipulates it and consults it from remote repos. > Notably, darcs copies the _darcs/prefs/sources from the remote repo and > augments it with local information. Editing _darcs/prefs/prefs should > be probably discouraged; editing the _darcs/prefs/sources on the other > hand... is maybe kosher. Confusing the issue is the fact that Darcs > does not currently handle the _darcs/prefs/sources very intelligently.
