webob decorator idea
Ian Bicking
def wsgify(func):
def replacement(req, *args, **kw):
if type(req) is dict:
environ = req
req = Request(environ)
start_response = args[0]
try:
resp = func(req)
except exc.HTTPException, resp:
pass
return resp(environ, start_response)
else:
return func(req, *args, **kw)
return replacement
I.e., it's a WSGI application and an undecorated function, and maybe it could seamlessly support WSGI 2 too.
--
Ian Bicking | http://blog.ianbicking.org
Sergey Schetinin
where no compromise is necessary. I had support for the same thing in
my decorator -- but it turned out I never needed to use it so I took
it out. It seems entirely possible to me that you're overestimating
the hassle associated with having to use a separate method in cases
when you need additional arguments etc.
(BTW, I think with this change checks for .wsgi_app in get_response in
dec branch can be taken out as well)
Best Regards,
Sergey Schetinin
http://s3bk.com/ -- S3 Backup
http://word-to-html.com/ -- Word to HTML Converter
Ian Bicking
I think this is much better, but still think that this is a compromise
where no compromise is necessary. I had support for the same thing in
my decorator -- but it turned out I never needed to use it so I took
it out. It seems entirely possible to me that you're overestimating
the hassle associated with having to use a separate method in cases
when you need additional arguments etc.
Well, it's a compromise that at least works given the differing opinion between the two of us. I'll probably also rethink the whole module too as it should simplify a bunch of things.
(BTW, I think with this change checks for .wsgi_app in get_response in
dec branch can be taken out as well)
Yeah, I made that change locally but I have some mess I need to straighten before I commit.
Ian
Sergey Schetinin
> On Tue, Jun 2, 2009 at 6:40 AM, Sergey Schetinin <mal...@gmail.com> wrote:
>
> > I think this is much better, but still think that this is a compromise
> > where no compromise is necessary. I had support for the same thing in
> > my decorator -- but it turned out I never needed to use it so I took
> > it out. It seems entirely possible to me that you're overestimating
> > the hassle associated with having to use a separate method in cases
> > when you need additional arguments etc.
> >
>
> Well, it's a compromise that at least works given the differing opinion
> between the two of us. I'll probably also rethink the whole module too as
> it should simplify a bunch of things.
Sure. I'd prefer to use components written with this dual-interface
decorator to the one proposed before, however I'm pretty sure I'll
stick to webob_wrap for my own stuff simply because I like *not*
having any features that wsgify adds. Simpler stuff makes thinking
about things easier and having so many ways to generate response seems
to encourage messy code (reminds me of pyzen). So what I'm saying is
that I'm glad it would be easier to use stuff as WSGI without knowing
anything else about it, and that's all that matters to me at this
point, so agreement reached. :)
BTW, I wonder if you will be taking the wsgify.reverse out?
> >
> > (BTW, I think with this change checks for .wsgi_app in get_response in
> > dec branch can be taken out as well)
> >
> >
> >
> >
>
> Yeah, I made that change locally but I have some mess I need to straighten
> before I commit.
>
> Ian
>
>
>
Kumar McMillan
> Is there anything really wrong about a decorator that looks roughly like
> this?
>
> def wsgify(func):
> def replacement(req, *args, **kw):
> if type(req) is dict:
> environ = req
> req = Request(environ)
> start_response = args[0]
> try:
> resp = func(req)
> except exc.HTTPException, resp:
Ian Bicking
On Tue, Jun 2, 2009 at 1:07 AM, Ian Bicking <ia...@colorstudy.com> wrote:will this except clause work for Python 2.4? Sad that I have to ask.
> Is there anything really wrong about a decorator that looks roughly like
> this?
>
> def wsgify(func):
> def replacement(req, *args, **kw):
> if type(req) is dict:
> environ = req
> req = Request(environ)
> start_response = args[0]
> try:
> resp = func(req)
> except exc.HTTPException, resp:
Yeah, HTTPException is always an exception, it's just things like HTTPNotFound that are not exception objects in Python 2.4.
Ian Bicking
of the Request class. This is what werkzeug does, which means that
it's very natural to use a subclass of Request. In werkzeug it is
called application, so it's like:
import webob
@webob.Request.application
def myapp(req):
return webob.Response(...)
Any thoughts on this? Request is of course a pretty big class
already, but then as a result this isn't proportionally much of an
increase in size ;) Middleware would work the same way.
Ian
Sergey Schetinin
Cons: It looks a bit ugly when no subclass is needed, "request
application" doesn't sound right and subclassing the decorator itself
is harder this way.
Overall I think these things deserve to be in their own / global namespace.
Also, nothing wrong with @wsgify(Request2) IMO.