"make fulltest" requires TAP::Harness::Archive

4 views
Skip to first unread message

Jonathan "Duke" Leto

unread,
Dec 25, 2011, 12:12:59 PM12/25/11
to parrot-dev
Howdy,

I was setting up Parrot on a new machine, which I have done many
times, but now I see that "make fulltest" now requires
TAP::Harness::Archive (even if you aren't sending to Smolder). Is this
on purpose? If so, the least we could do is give the user a nice
message about how to install or find TAP::Harness::Archive.

Our other option to only require THA if something is being sent to
Smolder, which seems to be more user-friendly behavior.

Duke

--
Jonathan "Duke" Leto <jona...@leto.net>
Leto Labs LLC
209.691.DUKE // http://labs.leto.net
NOTE: Personal email is only checked twice a day at 10am/2pm PST,
please call/text for time-sensitive matters.
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

James E Keenan

unread,
Jan 20, 2012, 8:59:22 PM1/20/12
to parro...@lists.parrot.org
On 12/25/11 12:12 PM, Jonathan "Duke" Leto wrote:

> Our other option to only require THA if something is being sent to
> Smolder, which seems to be more user-friendly behavior.
>

Please review the kid51/fulltest_easy now on github.

On this branch I have tested 'make fulltest', 'make smolder_fulltest'
and 'perl t/fullharness' successfully -- but of course all the boxes I
have available already have the necessary modules installed. So it
would be good to test on a box which lacks TAP::Harness::Archive or
anything in TAP-Harness-Multiple.

Thank you very much.
Jim Keenan
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Jonathan "Duke" Leto

unread,
Jan 21, 2012, 3:17:32 AM1/21/12
to James E Keenan, parro...@lists.parrot.org
Howdy,

> Please review the kid51/fulltest_easy now on github.
>
> On this branch I have tested 'make fulltest', 'make smolder_fulltest' and
> 'perl t/fullharness' successfully -- but of course all the boxes I have
> available already have the necessary modules installed.  So it would be good
> to test on a box which lacks TAP::Harness::Archive or anything in
> TAP-Harness-Multiple.

You can run test suites without modules with
https://metacpan.org/module/Test::Without::Module

like so:

perl -MTest::Without::Module=Some::Module -w -Iblib/lib t/SomeModule.t

I will test this out on my machine soon.

Jonathan "Duke" Leto

unread,
Jan 21, 2012, 3:19:30 AM1/21/12
to James E Keenan, parro...@lists.parrot.org
Howdy,

Just a few caveats about this module:

1) It does not support lexical scopes (it is file/package-wide, not sure which)
2) Certain core XS modules cannot be unloaded

Duke

Jonathan "Duke" Leto

unread,
Jan 21, 2012, 3:36:56 AM1/21/12
to James E Keenan, parro...@lists.parrot.org
Howdy,

I just merged master in and ran the tests on my machine and pushed it back to
your branch, but I haven't ran it correctly with the modules it checks for.
Please test the latest stuff in this branch and let me know.

Duke

--

James E Keenan

unread,
Jan 21, 2012, 7:52:37 AM1/21/12
to Jonathan "Duke" Leto, parro...@lists.parrot.org
On 1/21/12 3:17 AM, Jonathan "Duke" Leto wrote:
> Howdy,
>
>> Please review the kid51/fulltest_easy now on github.
>>
>> On this branch I have tested 'make fulltest', 'make smolder_fulltest' and
>> 'perl t/fullharness' successfully -- but of course all the boxes I have
>> available already have the necessary modules installed. So it would be good
>> to test on a box which lacks TAP::Harness::Archive or anything in
>> TAP-Harness-Multiple.
>
> You can run test suites without modules with
> https://metacpan.org/module/Test::Without::Module
>
> like so:
>
> perl -MTest::Without::Module=Some::Module -w -Iblib/lib t/SomeModule.t
>

Thanks for that suggestion. I installed that library and, with one
correction in the kid51/fulltest_easy branch to t/fullharness, this now
should work as intended:

$ perl -MTest::Without::Module=TAP::Harness::ReportByDescription
t/fullharness --archive --in-testing
To run make smolder_fulltest, please install
TAP::Harness::Archive and TAP::Harness::ReportByDescription from CPAN.
From the cpan shell: 'install TAP::Harness::ReportByDescription'.
With cpanminus : cpanm TAP::Harness::ReportByDescription
at t/fullharness line 68

$ perl -MTest::Without::Module=TAP::Harness::Archive t/fullharness
--archive --in-testing
To run make smolder_fulltest, please install
TAP::Harness::Archive and TAP::Harness::ReportByDescription from CPAN.
From the cpan shell: 'install TAP::Harness::ReportByDescription'.
With cpanminus : cpanm TAP::Harness::ReportByDescription
at t/fullharness line 68

$ perl -MTest::Without::Module=TAP::Harness::Archive t/fullharness
--in-testing
testb: running with: --runcore=bounds -D40 --gc-debug
testb__t/oo/attributes.t ...... ok
[snip]
headerizer: running with: -D40 --gc-debug
headerizer__t/tools/dev/headerizer/01_functions.t .. ok
headerizer__t/tools/dev/headerizer/02_methods.t .... ok
All tests successful.
Files=44, Tests=1357, 3 wallclock secs ( 0.23 usr 0.09 sys + 2.17
cusr 0.69 csys = 3.18 CPU)
Result: PASS
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

James E Keenan

unread,
Jan 26, 2012, 9:20:00 PM1/26/12
to parro...@lists.parrot.org

Are there any objections to merging this branch in?

Jonathan "Duke" Leto

unread,
Jan 26, 2012, 10:12:59 PM1/26/12
to James E Keenan, parro...@lists.parrot.org
+1 to merge now

--

James E Keenan

unread,
Jan 27, 2012, 8:09:48 AM1/27/12
to parro...@lists.parrot.org
On 1/26/12 10:12 PM, Jonathan "Duke" Leto wrote:
> +1 to merge now
>

I have merged the kid51/fulltest_easy branch into master.

When subsequently running make smolder_fulltest, I noticed a codingstd
failure:

$ prove -v t/codingstd/filenames.t
t/codingstd/filenames.t ..
1..3
not ok 1 - No multi-dot filenames

# Failed test 'No multi-dot filenames'
# at t/codingstd/filenames.t line 93.
# Multi-dot filename found in 1 files:
# .travis.yml
ok 2 - Portable characters in filenames
ok 3 - Filenames length
# Looks like you failed 1 test of 3.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
t/codingstd/filenames.t (Wstat: 256 Tests: 3 Failed: 1)
Failed test: 1
Non-zero exit status: 1
Files=1, Tests=3, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.19 cusr
0.01 csys = 0.24 CPU)
Result: FAIL

Can you add an exception in t/codingstd/filenames.t to account for this
hidden file?

Jonathan "Duke" Leto

unread,
Jan 27, 2012, 11:53:45 AM1/27/12
to James E Keenan, parro...@lists.parrot.org
Reply all
Reply to author
Forward
0 new messages