[p4a.plonecalendar] p4a.ploneevent dependency

[Andreas Jung]

Hi there,

p4a.plonecalendar defines p4a.ploneevent as dependency in its setup.py
(and has some setup code within p4a.plonecalendar). This is a very
hard-coded
and unnecessary dependency. First, using schemaextender for extending
the schema
of ATEvent site-wide and instance-wide is a pretty big hammer and
second, there is
no way to use p4a.plonecalendar with a custom event implementation
(vs.event derives
from ATEvent) not using recurrence or in a different way. I recommend
that this
dependencies should be removed (separation of concerns) - all ploneevent
related
setup code should be moved into the p4a.ploneevent implementation or at
least the
setup code in p4a.plonecalendar should work without ploneevent. This means:

- remove the p4a.ploneevent dependency from the setup.py
- let the p4a.plonecalendar setup code check if ploneevent is installed

If you want to use p4a.ploneevent, specify it as an explicit dependency
in your
buildout.cfg.

Thoughts?

Andreas

--
ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany
Web: www.zopyx.com - Email: in...@zopyx.com - Phone +49 - 7071 - 793376
Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535
Geschäftsführer/Gesellschafter: ZOPYX Limited, Birmingham, UK
------------------------------------------------------------------------
E-Publishing, Python, Zope & Plone development, Consulting

[Lennart Regebro]

2009/6/13 Andreas Jung <li...@zopyx.com>:

> Hi there,
>
> p4a.plonecalendar defines p4a.ploneevent as dependency in its setup.py
> (and has some setup code within p4a.plonecalendar). This is a very
> hard-coded and unnecessary dependency.

I agree, this is a mistake.

--
Lennart Regebro: Python, Zope, Plone, Grok
http://regebro.wordpress.com/
+33 661 58 14 64

[Nate Aune]

On Sat, Jun 13, 2009 at 5:42 AM, Lennart Regebro<len...@jazkarta.com> wrote:
>
> 2009/6/13 Andreas Jung <li...@zopyx.com>:
>> Hi there,
>>
>> p4a.plonecalendar defines p4a.ploneevent as dependency in its setup.py
>> (and has some setup code within p4a.plonecalendar). This is a very
>> hard-coded and unnecessary dependency.
>
> I agree, this is a mistake.

Can you take some time to clean it up as Andreas suggests?

thanks,
Nate

--
Nate Aune - na...@jazkarta.com
http://www.jazkarta.com

[Lennart Regebro]

2009/6/14 Nate Aune <na...@jazkarta.com>:

> Can you take some time to clean it up as Andreas suggests?

Already done.

[si si]

2009/6/14 Lennart Regebro <len...@jazkarta.com>:

>
> 2009/6/14 Nate Aune <na...@jazkarta.com>:
>> Can you take some time to clean it up as Andreas suggests?
>
> Already done.

Hey Lennart,

will these changes be on pypi any time soon? I was all set to install
p4a.plonecalendar version 2.0a3 on our website today. I'd wait if you
were going to release these changes soon. I won't wait that long
though, I'm very hyped at having the calendar finally. It rocks :-)

Cheers,
sisi

[Lennart Regebro]

2009/6/17 si si <pud...@gmail.com>:

>
> 2009/6/14 Lennart Regebro <len...@jazkarta.com>:
>>
>> 2009/6/14 Nate Aune <na...@jazkarta.com>:
>>> Can you take some time to clean it up as Andreas suggests?
>>
>> Already done.
>
> Hey Lennart,
>
> will these changes be on pypi any time soon? I was all set to install
> p4a.plonecalendar version 2.0a3 on our website today. I'd wait if you
> were going to release these changes soon. I won't wait that long
> though, I'm very hyped at having the calendar finally. It rocks :-)
>
> Cheers,
> sisi

I hope to make a release this week. I'm waiting for a Norwgian translation. :)