Oracle enhanced adapter and ActiveRecord unit tests

[rwc9u]

I was trying to run the ActiveRecord unit tests for edge rails against
the oracle_enhanced adapter and the last version of the oracle
adapter, and neither passes. I'd like to submit patches to get the
adapter to pass the tests. Do you want pull requests via github or
would you like separate patches submitted via lighthouse, or links to
a branch with a specific feature change?


Thanks,

Rob

[Raimonds Simanovskis]

I tried to run ActiveRecord unit tests several months ago and got
about 100 failing tests - I started to fix some issues but there were
many things where it seems for me that would be hard to achieve 100%
success. Several hard issues were
- SQL statements with conditions on CLOB columns which Oracle does not
support
- auto-generated table / index / sequence names with more than 30
characters
- some AR unit tests are written not correctly - e.g. integer tests on
boolean columns

But it would be great if you could help with reducing the number of
failing tests :)

The best way would be if you would do your patches on your forked git
repository and try to make each fix in a separate commit - then I
could apply these individual commits to my repository.

Currently I am doing major refactoring of oracle_enhanced adapter to
support JRuby - I have already initial version ready and pushed it to
http://github.com/rsim/oracle-enhanced/tree/jruby
So I am planning to release it as adapter version 1.2.0.

After that I (with your help :)) could continue to work on fixes for
AR unit tests. I had one idea to patch automatic table / index /
sequence name generation so that it would always be less than 30
characters.

Kind regards,
Raimonds

[rwc9u]

I see what you mean by the CLOB columns. Many of the ActiveRecord
tests assume you can group by or order by a CLOB column. I started
looking at how other adapters handle these issues. The SQLServer
adapter takes the approach of undefining the existing test in the
rails test suite and redefining a test that is SQLServer compatible.
That looks like the only route to go for these tests because I can't
imagine conditional tests being added to rails core for the oracle
adapter since it got pulled out.

Rob

On Jan 7, 4:54 pm, Raimonds Simanovskis

<raimonds.simanovs...@gmail.com> wrote:
> I tried to run ActiveRecord unit tests several months ago and got
> about 100 failing tests - I started to fix some issues but there were
> many things where it seems for me that would be hard to achieve 100%
> success. Several hard issues were
> - SQL statements with conditions on CLOB columns which Oracle does not
> support
> - auto-generated table / index / sequence names with more than 30
> characters
> - some AR unit tests are written not correctly - e.g. integer tests on
> boolean columns
>
> But it would be great if you could help with reducing the number of
> failing tests :)
>
> The best way would be if you would do your patches on your forked git
> repository and try to make each fix in a separate commit - then I
> could apply these individual commits to my repository.
>
> Currently I am doing major refactoring of oracle_enhanced adapter to

> support JRuby - I have already initial version ready and pushed it tohttp://github.com/rsim/oracle-enhanced/tree/jruby