Re: Minor patch for ruote-web's WorkitemHelper

[John Mettraux]

On Wed, May 7, 2008 at 10:20 PM, Arjan van Bentem <avbe...@dds.nl> wrote:
>
> http://github.com/jmettraux/ruote-web/tree/1c6b31fdb1ff24d181ab3724401ff79fe2e6ec19/app/helpers/workitem_helper.rb#L50
>
> from_view = (request.env['HTTP_REFERER'].match("/view/") != nil)
>
> yields a problem when refreshing the page, as then
> request.env['HTTP_REFERER'] is nil (well, it is on my Firefox on WinXP). Of
> course you know, it's easily fixed using:
>
> from_view = (request.env['HTTP_REFERER'].match("/view/") != nil) if
> request.env['HTTP_REFERER']
>
> or exactly the same number of characters for:
>
> from_view = request.env['HTTP_REFERER'] &&
> (request.env['HTTP_REFERER'].match("/view/") != nil)

Thanks a lot Arjan !

I will integrate that right now.

Cheers,

--
John Mettraux - http://jmettraux.wordpress.com

[John Mettraux]

> On Wed, May 7, 2008 at 10:20 PM, Arjan van Bentem <avbe...@dds.nl> wrote:
> >
> > http://github.com/jmettraux/ruote-web/tree/1c6b31fdb1ff24d181ab3724401ff79fe2e6ec19/app/helpers/workitem_helper.rb#L50
> >
> > from_view = (request.env['HTTP_REFERER'].match("/view/") != nil)
> >
> > yields a problem when refreshing the page, as then
> > request.env['HTTP_REFERER'] is nil (well, it is on my Firefox on WinXP). Of
> > course you know, it's easily fixed using:
> >

> > from_view = request.env['HTTP_REFERER'] &&
> > (request.env['HTTP_REFERER'].match("/view/") != nil)

OK, it's in. Tell me if it works OK for you, I changed the regexp somehow.

Thanks again,