OBA GTFS wheelchair accessibility information support

10 views
Skip to first unread message

David Turner

unread,
Dec 3, 2009, 2:23:14 PM12/3/09
to opentripplanner-dev
There's a proposal on GTFS-changes to add wheelchair accessibility
information to GTFS. I have written a patch to OBA's GTFS loader (used
by OTP) to read this information in. It is attached. I also have the
relevant changes made to OTP to use this information, and will commit
them once a new OBA-GTFS is released.
oba-gtfs-wheelchair.patch

David Turner

unread,
Dec 3, 2009, 2:27:11 PM12/3/09
to opentripp...@googlegroups.com
Sorry, I meant this version of the patch. Stupid mail client cached it.
oba-gtfs-wheelchair.patch

Brian Ferris

unread,
Dec 4, 2009, 2:46:34 AM12/4/09
to opentripp...@googlegroups.com
Hey David,

Happy to add this functionality.  I'm wondering if you'd be willing to add a simple unit test as well?  Or at least send me a snippet of a stops.txt file that has the wheelchair column set?

Brian

David Turner

unread,
Dec 4, 2009, 10:27:46 AM12/4/09
to opentripp...@googlegroups.com
I wrote the unit test in OTP rather than in OBA, so let me send you the
updated test gtfs for that.
testagency.zip

Brian Ferris

unread,
Dec 4, 2009, 11:08:54 AM12/4/09
to opentripp...@googlegroups.com
I just read over the original wheelchair_accessible thread:

http://groups.google.com/group/gtfs-changes/browse_thread/thread/f98f8fa7c4cc8430/a2a75c3841f48ae9

Do you have any thoughts about making the field an int instead of a boolean?  This would make it easier to support expanding the values of "wheelchair_accessible" in the future, especially if an agency wanted to provide "accessible, but with a caveat" data as discussed in the thread.

Brian

David Turner

unread,
Dec 4, 2009, 11:13:05 AM12/4/09
to opentripp...@googlegroups.com
I chose to do a boolean because I wanted to keep it simple. I think
accessible-with-notes can still be provided for -- if the notes column
is non-empty, the stop or trip is accessible-with-notes.

If you do decide to go with an integer, tho, that's cool. I'll just
change the otp code.

David Turner

unread,
Dec 10, 2009, 10:23:16 PM12/10/09
to opentripp...@googlegroups.com
Just writing to make sure this didn't get lost. Since my changes to OTP
for wheelchair accessibility involved some changes to testagency.zip,
merging is a pain in the butt. Can you either merge this patch and
release a new version, or tell me what I need to change to get the patch
accepted?

Brian Ferris

unread,
Dec 11, 2009, 1:45:18 AM12/11/09
to opentripp...@googlegroups.com
Sorry about the delay.  It's definitely on my radar, but I've been slammed this week and I haven't been able to get around to an official release.  I will try to get to it tonight / tomorrow.

Brian Ferris

unread,
Dec 11, 2009, 4:00:30 PM12/11/09
to opentripp...@googlegroups.com
I've just checked in updates to the onebusaway-gtfs library (released as 1.0.3) to support David's wheelchair accessibility modifications.  

Additionally, the updated library has better methods for determining if a value has been supplied for an optional field represented by a primitive type. I've opened a ticket for this issue:


I will try to go through and make changes where necessary, but it's a little bit of a subtle issue, so keep your eyes open.

Brian
Reply all
Reply to author
Forward
0 new messages