Comment on revision r36 in opensocial-ruby-client
codesite...@google.com
opensocial-ruby-client.
Details are at
http://code.google.com/p/opensocial-ruby-client/source/detail?r=36
Score: Neutral
General Comment:
I've flagged a few indentation/spacing issues in the first few files, but
they apply throughout. Please make sure the indentation and spacing is
consistent.
I'm also unsure of the decision to handle the HTTP method in the connection
class versus the individual request (see comments in connection.rb).
Do you have tests for these changes? Do the existing tests pass?
Line-by-line comments:
File: /trunk/lib/opensocial/activity.rb (r36)
===============================================================================
Line 126: # Initializes a request to update activities for the specified
user and
-------------------------------------------------------------------------------
Indenting.
Line 134: # Sends the request, passing in the appropriate SERVICE and
specified
-------------------------------------------------------------------------------
Indenting.
File: /trunk/lib/opensocial/album.rb (r36)
===============================================================================
Line 20: def initialize(json)
-------------------------------------------------------------------------------
Indenting.
Line 28: def set_values(json)
-------------------------------------------------------------------------------
Indenting.
Line 62: # Initializes a request to fetch albums for the specified user and
-------------------------------------------------------------------------------
Indenting.
Line 70: # Sends the request, passing in the appropriate SERVICE and
specified
-------------------------------------------------------------------------------
Indenting.
Line 78: # Selects the appropriate fragment from the JSON response in
order to
-------------------------------------------------------------------------------
Indenting.
Line 84: # Converts the request into a JSON fragment that can be used as
part of a
-------------------------------------------------------------------------------
Indenting.
Line 117: # Initializes a request to update(Post, Put, Delete) albums for
the specified user and
-------------------------------------------------------------------------------
Indenting.
Line 125: # Sends the request, passing in the appropriate SERVICE and
specified
-------------------------------------------------------------------------------
Indenting.
Line 133:
-------------------------------------------------------------------------------
Extra whitespace.
File: /trunk/lib/opensocial/connection.rb (r36)
===============================================================================
Line 33:
-------------------------------------------------------------------------------
Am I to understand that I initialize the connection differently depending
on whether I am GETting, POSTing, etc.? It seems like I should be able to
re-use my connection for multiple requests to the same container and that
the HTTP method would be automatically decided for me based on the type of
request I was sending (get activities versus create activitity).
Respond to these comments at
http://code.google.com/p/opensocial-ruby-client/source/detail?r=36
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings