Opensocial Templates minor spec updates

0 views
Skip to first unread message

Adam Winer

unread,
Apr 1, 2009, 12:02:17 PM4/1/09
to ♫
+1 on the whole, but some content tweaks suggested.


http://codereview.appspot.com/28162/diff/1/2
File draft/OpenSocial-Templating.xml (right):

http://codereview.appspot.com/28162/diff/1/2#newcode134
Line 134: Expressions are honored XML inside text nodes and attribute
values. They will
honored XML?

http://codereview.appspot.com/28162/diff/1/2#newcode195
Line 195: <t>@disabled attribute of the &lt;input&gt;, &lt;button&gt;,
&lt;select&gt; and &lt;textarea&gt; tags</t>
missing attributes:

readonly, on input and textarea
ismap on input and img
disabled on optgroup
multiple on select
defer on script
compact on DIR, DL, MENU, OL, UL,
etc....  it's actually a long list.

Recommend stating this applies to all boolean HTML attributes and not
trying to copy the full list.

http://codereview.appspot.com/28162/diff/1/2#newcode690
Line 690: be sanitized away. Containers should allow minimal
functionality such as making text bold or changing its color,
+1 to allowing sanitization.  Glad to see this in there.

http://codereview.appspot.com/28162

Scott Seely

unread,
Apr 1, 2009, 12:23:41 PM4/1/09
to opensocial-an...@googlegroups.com

http://codereview.appspot.com/28162/diff/1/2#newcode195

Line 176: let’s re-word ‘“falsey” value’ as ‘value that evaluates to false in JavaScript’. “Falsey” is pronounced the same as “falsie.” I’m not being a prude so much as I don’t want notions of brassiere stuffing to be baked into the specJ

 

(http://www.thefreedictionary.com/falsie)

Lev Epshteyn

unread,
Apr 1, 2009, 1:49:03 PM4/1/09
to opensocial-an...@googlegroups.com
Heh, the things you miss out on when English is your second language :)

In Javascript, !!"false" == true, and I think the string "false" should evaluate to boolean false in our case. I am ready to use language that doesn't make anyone think of boobies, but don't think invoking Javascript here gives us the proper definition. I actually could have sworn I saw/heard "falsey" used to specify precisely this.

Any other suggestions?

Lev Epshteyn

unread,
Apr 1, 2009, 2:54:11 PM4/1/09
to opensocial-an...@googlegroups.com
How about "false-like"?

Kevin Brown

unread,
Apr 1, 2009, 2:56:37 PM4/1/09
to opensocial-an...@googlegroups.com
On Wed, Apr 1, 2009 at 11:54 AM, Lev Epshteyn <le...@google.com> wrote:
How about "false-like"?

Not truthy?
 

Scott Seely

unread,
Apr 1, 2009, 3:21:22 PM4/1/09
to opensocial-an...@googlegroups.com

False-like or false equivalent are both good choices.

Lev Epshteyn

unread,
Apr 1, 2009, 5:00:22 PM4/1/09
to opensocial-an...@googlegroups.com
Updated. All the comments addressed.

Scott Seely

unread,
Apr 1, 2009, 5:06:16 PM4/1/09
to opensocial-an...@googlegroups.com

Thanks, Lev. Looks good.

+1

 

If anyone objects to these edits, please speak up. Otherwise, Lev should be asking Arne to perform a commit tomorrow afternoon.

Lev Epshteyn

unread,
Apr 2, 2009, 12:24:46 PM4/2/09
to opensocial-an...@googlegroups.com, Arne Roomann-Kurrik
Arne, can you commit this if there are no objections over the next few hours?

Arne Roomann-Kurrik

unread,
Apr 2, 2009, 4:20:30 PM4/2/09
to Lev Epshteyn, opensocial-an...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages