Re: Clarify Separation of Gadgets (Data Sections)

[llia...@google.com]

This is really coming together!


http://codereview.appspot.com/154120/diff/2001/3001
File draft/Social-Data.xml (right):

http://codereview.appspot.com/154120/diff/2001/3001#newcode20
draft/Social-Data.xml:20: <t>This document defines all the data objects
used in the OpenSocial APIs.</t>
Please update this to explain that it extends the Core-Data spec with
data objects used in the Social-Gadget and Social-API-Server specs.

http://codereview.appspot.com/154120/diff/2001/3001#newcode120
draft/Social-Data.xml:120: anchor="primary-social-data">
Please add a <t></t> here explaining what Primary Social Data is (and
how it's different from "Additional Social Data". Just a sentence or
two should suffice.

http://codereview.appspot.com/154120/diff/2001/3001#newcode553
draft/Social-Data.xml:553: <section title="Additional Social Data">
Please add a <t></t> element describing 'Additional Social Data' (and
how it's different from Primary Social Data. One or two sentences
should suffice.

http://codereview.appspot.com/154120/diff/2001/3001#newcode632
draft/Social-Data.xml:632: <section title="OpenSocial Group ID"
Title should be Group ID, not OpenSocial Group ID. (I think I prefer
Group-ID, so it matches the anchor and identifiers w/o spaces are better
for the ABNF in the API-Server.xml)

http://codereview.appspot.com/154120

[llia...@google.com]

A preview of these files is available at:

http://www.opensocial.org/Technical-Resources/draft/Core-Data.xml

and

http://www.opensocial.org/Technical-Resources/draft/Social-Data.xml

http://codereview.appspot.com/154120

[Jon]

Patch updated to address Lane's comments.

[llia...@google.com]

+1


http://codereview.appspot.com/154120/diff/2004/3009
File draft/Social-Data.xml (right):

http://codereview.appspot.com/154120/diff/2004/3009#newcode21
draft/Social-Data.xml:21: OpenSocial APIs. Object here will make use of
the <xref
Object --> Objects defined

http://codereview.appspot.com/154120/diff/2004/3009#newcode25
draft/Social-Data.xml:25: <t>JavaScript withing the gadget will be done
using osapi APIs,
withing --> within

http://codereview.appspot.com/154120/diff/2004/3009#newcode31
draft/Social-Data.xml:31: </t>
General preference for present tense (e.g. REST and RPC access *is* done
using...). If you agree, try searching for "will" throughout.

http://codereview.appspot.com/154120

[jon.we...@gmail.com]

Fixed the typos and grammer

http://codereview.appspot.com/154120

[Tim Moore]

+1 for the patch as a whole

[Jacky]

big +1 for submit it after the whole reviewing.

[Lane LiaBraaten]

That's 4 +1's

...nudge...

--

You received this message because you are subscribed to the Google Groups "OpenSocial and Gadgets Specification Discussion" group.
To post to this group, send email to opensocial-an...@googlegroups.com.
To unsubscribe from this group, send email to opensocial-and-gadg...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/opensocial-and-gadgets-spec?hl=en.

[Chris Chabot]

+1 to make it 5 :)

[Lane LiaBraaten]

Great - I'll commit the patch this afternoon.

[Lane LiaBraaten]

Committed: http://code.google.com/p/opensocial-resources/source/detail?r=1204

Thanks everyone - this is a significant patch!

-Lane

[goosemanjack]

-0

Stop the presses. Some significant features have been lost in
translation.

We need to add Dynamic Parameters back into the Core-Gadget spec.
There is also no specific mention of EL in the new spec structure that
I can tell, except in passing within the Template spec.

The following items should be worked back into the Core-Gadgets spec:

* Dynamic Parameters
* EL statements

Under the new spec structure these tags should be moved to the
OpenSocial or the Templating spec, unless we are specifically
proposing to deprecate them.

* tag <os:ViewerRequest>
* tag <os:PeopleRequest>
* tag <os:OwnerRequest>
* tag <os:ActivitiesRequest>

--
clc

On Dec 1 2009, 5:53 pm, Lane LiaBraaten <lliab...@google.com> wrote:
> Committed:http://code.google.com/p/opensocial-resources/source/detail?r=1204
>
> Thanks everyone - this is a significant patch!
>
> -Lane
>

> On Tue, Dec 1, 2009 at 11:25 AM, Lane LiaBraaten <lliab...@google.com>wrote:
>
> > Great - I'll commit the patch this afternoon.
>

> > On Tue, Dec 1, 2009 at 9:19 AM, Chris Chabot <chab...@google.com> wrote:
>
> >> +1 to make it 5 :)
>

> >> On Tue, Dec 1, 2009 at 6:06 PM, Lane LiaBraaten <lliab...@google.com>wrote:
>
> >>> That's 4 +1's
>
> >>> ...nudge...
>

> >>> On Tue, Dec 1, 2009 at 2:56 AM, Jacky <jacky.chao.w...@gmail.com> wrote:
>
> >>>> big +1 for submit it after the whole reviewing.
>
> >>>> On Nov 25, 7:13 am, Tim Moore <tmo...@atlassian.com> wrote:
> >>>> > +1 for the patch as a whole
>
> >>>> --
>
> >>>> You received this message because you are subscribed to the Google
> >>>> Groups "OpenSocial and Gadgets Specification Discussion" group.
> >>>> To post to this group, send email to
> >>>> opensocial-an...@googlegroups.com.
> >>>> To unsubscribe from this group, send email to

> >>>> opensocial-and-gadg...@googlegroups.com<opensocial-and-gadgets-spec%2Bunsu...@googlegroups.com>

> >>>> .
> >>>> For more options, visit this group at
> >>>>http://groups.google.com/group/opensocial-and-gadgets-spec?hl=en.
>
> >>>  --
> >>> You received this message because you are subscribed to the Google Groups
> >>> "OpenSocial and Gadgets Specification Discussion" group.
> >>> To post to this group, send email to
> >>> opensocial-an...@googlegroups.com.
> >>> To unsubscribe from this group, send email to

> >>> opensocial-and-gadg...@googlegroups.com<opensocial-and-gadgets-spec%2Bunsu...@googlegroups.com>

> >>> .
> >>> For more options, visit this group at
> >>>http://groups.google.com/group/opensocial-and-gadgets-spec?hl=en.
>
> >>  --
> >> You received this message because you are subscribed to the Google Groups
> >> "OpenSocial and Gadgets Specification Discussion" group.
> >> To post to this group, send email to
> >> opensocial-an...@googlegroups.com.
> >> To unsubscribe from this group, send email to

> >> opensocial-and-gadg...@googlegroups.com<opensocial-and-gadgets-spec%2Bunsu...@googlegroups.com>

[Lane LiaBraaten]

On Wed, Jan 13, 2010 at 10:42 PM, goosemanjack <cc...@myspace.com> wrote:

-0

Stop the presses.  Some significant features have been lost in
translation.

We need to add Dynamic Parameters back into the Core-Gadget spec.
There is also no specific mention of EL in the new spec structure that
I can tell, except in passing within the Template spec. 

The following items should be worked back into the Core-Gadgets spec:

* Dynamic Parameters
* EL statements

You're right...I'm not sure how I missed it.

I think the Dynamic Parameters section [1] can just be copied over into the Core-Gadget -> Data Pipelining section.

Where is the section on EL statements that you're referring to?

[1] http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Data-Pipelining.html#rfc.section.15

Under the new spec structure these tags should be moved to the
OpenSocial or the Templating spec, unless we are specifically
proposing to deprecate them.

* tag <os:ViewerRequest>
* tag <os:PeopleRequest>
* tag <os:OwnerRequest>
* tag <os:ActivitiesRequest>

These tags are in Social-Gadget.xml, under the Data Pipelining section, so I think we're all good here.

-Lane

To unsubscribe from this group, send email to opensocial-and-gadg...@googlegroups.com.