Patch for radically simplify the persistence API

3 views
Skip to first unread message

awi...@gmail.com

unread,
Mar 30, 2009, 7:08:50 PM3/30/09
to api.k...@google.com, opensocial-an...@googlegroups.com
+1 to all of these changes.

http://codereview.appspot.com/28142

bobe...@google.com

unread,
Mar 31, 2009, 2:25:55 PM3/31/09
to api.k...@google.com, awi...@gmail.com, opensocial-an...@googlegroups.com

Louis Ryan

unread,
Mar 31, 2009, 4:36:31 PM3/31/09
to opensocial-an...@googlegroups.com, api.k...@google.com, awi...@gmail.com
+1

On Tue, Mar 31, 2009 at 11:25 AM, <bobe...@google.com> wrote:

+1

Scott Seely

unread,
Mar 31, 2009, 5:19:13 PM3/31/09
to opensocial-an...@googlegroups.com, api.k...@google.com, awi...@gmail.com

Lines 388-391 of the new are redundant with the OpenSocial API, section 5.3.12.2.14 newUpdatePersonAppDataRequest. Repetition means we need to maintain the values globally when we update the specs. This is also mentioned in the osapi.appdata section of the patch.

 

Suggestion: Remove the edits about 10 KB globally. Add a sentence to 3. Compliance, stating that the container SHOULD provide 10 KB for AppData.

 

REST-API: XSD is missing a modification to support AppData as an additional element in Person.

Arne Roomann-Kurrik

unread,
Apr 2, 2009, 6:52:13 PM4/2/09
to OpenSocial - OpenSocial and Gadgets Specification Discussion
Updated http://codereview.appspot.com/28142 with Scott's feedback.

~Arne
> On Tue, Mar 31, 2009 at 11:25 AM, <bobev...@google.com> wrote:
>
> +1
>
> http://codereview.appspot.com/28142

Scott Seely

unread,
Apr 3, 2009, 12:18:17 PM4/3/09
to opensocial-an...@googlegroups.com
Looks fine.

We haven't seen a lot of activity on this clarification. Let's plan on committing this at EOD if we see no objections.

Arne Roomann-Kurrik

unread,
Apr 6, 2009, 1:39:28 PM4/6/09
to OpenSocial - OpenSocial and Gadgets Specification Discussion
Committed: http://code.google.com/p/opensocial-resources/source/detail?r=1084

~Arne

On Apr 3, 9:18 am, Scott Seely <sSe...@myspace-inc.com> wrote:
> Looks fine.
>
> We haven't seen a lot of activity on this clarification. Let's plan on committing this at EOD if we see no objections.
>
> > -----Original Message-----
> > From: opensocial-an...@googlegroups.com [mailto:opensocial-and-
> > gadget...@googlegroups.com] On Behalf Of Arne Roomann-Kurrik
> > Sent: Thursday, April 02, 2009 3:52 PM
> > To: OpenSocial - OpenSocial and Gadgets Specification Discussion
> > Subject: [opensocial-and-gadgets-spec] Re: Patch for radically simplify the
> > persistence API
>
> > Updatedhttp://codereview.appspot.com/28142with Scott's feedback.
Reply all
Reply to author
Forward
0 new messages