Upload Form Question

25 views
Skip to first unread message

hippeelee

unread,
Mar 20, 2012, 12:44:44 PM3/20/12
to OpenPhoto
Hi,

This project is my first attempt to contribute to an open source
project so please let me know if my etiquette is not appropriate for
this project.

I am looking at this issue: https://github.com/openphoto/frontend/issues/339
which doesn't post the custom license text input when a user has the
*Custom* option selected in the /photos/upload form.

I'm using a program called Charles (as well as error logging the
$_POST & $REQUEST arrays) and that field is not included in the
request when the form is posted. Playing around, I tried to add some
test inputs in different places within the form to see if they would
get sent - they were not when I submitted the form.

Is there something I am missing? Is there something different about
this form that I am not aware of that would not include certain inputs
fields?

Thanks,

Matt

Jaisen Mathai

unread,
Apr 7, 2012, 3:00:06 AM4/7/12
to open...@googlegroups.com
Matt,

My apologies for not getting back with you sooner. Life's been really hectic and my inbox was the first casualty of it :).

That being said, we did a bit of work on the upload UI to move it to a shared location so all themes could use it. As part of that I actually removed the "CUSTOM" option but I'd like to add it back in. Just a heads up if you update and notice it's not there.

We're using plupload for the uploading. The POST params are set inside the JS code which can be found here, https://github.com/openphoto/frontend/blob/master/src/html/assets/javascripts/openphoto-upload.js#L73

The form parameters need to be explicitly included here in the JS for the server to receive them with each photo post.

Thanks,

Jaisen
Reply all
Reply to author
Forward
0 new messages