Broken "next" and "prev" links

[Adrian Tritschler]

Having just uploaded another batch of my old photos I've found that the "next" and "prev" links can be broken, there are several hundred of my photos that have just vanished from the gallery and never appear!  If I just to them by a remembered URL, or link from a tag I can find them.

Scrolling down through the gallery in a browser I get to http://openphoto.ajft.org/p/2uh but then the "+ load more" link enters into a loop showing me a group of 24 photos and then back to ./2uh.  I can scroll forever and they'll keep reloading the same set, but never see any photos older than that.

Is there some sort of consistency check that can be run at the database to ensure that each photo record has one (and only one) "next" and "prev" link so that there are no loops or omitted photos?

[Jaisen Mathai]

Yup. This is an old bug. Looks like you've had it for a while (https://github.com/openphoto/frontend/issues/496).

I haven't had a look because I don't have enough photos in any of my development environments to reproduce it. Though I realize that's just a lazy excuse.

It affects my account as well and appears to begin on page 40. Thanks for bring this back to our attention. I'll have a look at this tomorrow.

[Adrian Tritschler]

Apologies for reporting known problems, I went a little cross eyed reading through the issue tracker and wasn't sure what was a new bug, or a new bug that was similar to an old one.

  Adrian

[Jaisen Mathai]

No apologies needed. Better to have a bug reported 2x than 0x.

There's a rich history of duplicate issues being reported because 1) we're probably not as descriptive as we should be and don't reclassify issues when opened and 2) Github's search could use some improvement :)

[Jaisen Mathai]

Wow, cross posting my comment on Github.
https://github.com/openphoto/frontend/issues/496#issuecomment-6500894

-----

And the idiot award goes to @jmathai.

Have a look at this wonderful line of code.
https://github.com/openphoto/frontend/blob/master/src/libraries/adapters/DatabaseMySql.php#L1311

It's taken from the SimpleDb adapter which works quite differently and I must have never changed this line. Anyways, I was naive to think 100k photos per user was a very safe upper limit anyways.

[Adrian Tritschler]

40 seems a good number :)  Who could possibly need more than that...  Next you'll be telling me that 640k is a good size for a memory.

Let's see... the iPhoto app says I've got 2,860 photos (which is a nice touch, missing from the web interface... hint hint )

Quick check on my phone, 24 photos shown per page, should kick in at 960 of 2860...  Scroll, click, scroll, click, ... x38. 

Yep, looks as though you've found it.

  Adrian