OI FlashLight

[Shalin Shah]

Sir,

              As per the features request and requests on OI-uservoice website , I would like to work on these features :-

1) In random mode if double tapped a screen or maybe longclicked then make that color stagnant and on doing same process again switch back to random color.

2) Also could adjust the frequency of the changing of colors in random mode.

3)Add the widget for the Flash Light so that directly the flash can be turned on/off from the home screen.

4)Make change in color smoothly during the random color mode.

5)Make brightness setter so as to use brightness of Flashlight judiciously.

6)Store the color value in preferences so that every time user open the app it would open with the color he saved in preferences and if not saved then white.

Should I start working on these features?And I am really sorry for any undisciplined or wrong posts made before and I assure that this would not happen again.

Yours Sincerely,

Shalin Shah 

[Friedger Müffke]

Sound great, yes!

2013/1/28 Shalin Shah <shalins...@gmail.com>

--
You received this message because you are subscribed to the Google Groups "OpenIntents" group.
To post to this group, send email to openi...@googlegroups.com.
To unsubscribe from this group, send email to openintents...@googlegroups.com.
Visit this group at http://groups.google.com/group/openintents?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Shalin Shah]

sir,

I have done that onlong click the color change stops and again on longpress the color change resumes but when I do a longpress the icon visiblity also turns on and off should I make it visible permenantly ?Also many people like that icon very much I saw there comments on market.

Yours Sincerely ,

Shalin Shah

[Friedger Müffke]

Could you please add the commits when you post here? Maybe even an apk for testing.

2013/1/29 Shalin Shah <shalins...@gmail.com>

Shalin Shah

--

You received this message because you are subscribed to the Google Groups "OpenIntents" group.

To unsubscribe from this group and stop receiving emails from it, send an email to openintents...@googlegroups.com.

To post to this group, send email to openi...@googlegroups.com.

[Shalin Shah]

Sir,

              Please have a look the OI Flash Light with added features. 

[Shalin Shah]

The code link: https://github.com/shalinshah1993/flashlight.git 

[aap]

Hi Shalin,

As I mentioned in git comments, your commits include a bunch of generated binary files that are not supposed to be in the repository. 

I don't usually get involved with OI Flashlight, but I did just copy the .gitignore file from OI Shopping List so that the generated files will be ignored going forward.

Now you just have to redo your commits to include only the files you want. It should be relatively straightforward. Here's one approach, which will perhaps unfortunately fold all your changes into a single commit.

First you need to make sure you have a git remote for the official OI repo. If you don't already, you can add it like this:

git remote add upstream g...@github.com:openintents/flashlight.git

Then fetch the latest changes from upstream:

git fetch upstream

Now, to roll back your commits in your local repository, but leave your code changes intact in your working tree:

git reset 2b7102db831eb7e17fd2fb5a6f84e74d1abcdf41

Now add the gitignore file:

git merge upstream/master

If there were conflicts between the latest changes on master and your working tree, you would have to merge them at this point... but that won't be an issue in this case unless you have added your own .gitignore file.

From here, your repo is in sync with upstream, and you have changes to commit. It's a good idea to use "git status" to see what files git thinks you have changed, and use "git add" to add only the files you want to commit. You can also use "gitk" or "git diff" to see the changes in your working tree vs the repository. One thing to watch out for is to avoid making whitespace / formatting changes in the same commit as real code changes, because that makes life difficult for reviewers by obscuring your real code changes. After you "git add" everything you want to commit, use "git commit" and add a commit message that describes the specific goals of the commit. For example "Add widget" or "New features" (ideally with an outline of the new features" would be good commit messages, while just saying "changes" or "modified foo.java" don't really add value.

It's good practice to review your commit in gitk before pushing to github, or at least to review what it looks like on github before posting to the developer list asking for review. Try to think like a reviewer and find things that could be done more cleanly, and if you do find them, you can always redo the commit before showing your code to everyone.

Once you are happy with the way the commit looks, post again here. The code is primary, so a link to a specific commit or branch that you want reviewed is critical... but it doesn't hurt to add an apk attachment to facilitate testing.

-- Aaron

[Shalin Shah]

Sir,

Thank-you aaron sir for this explanation it was really very helpful now i pushed it again and i was able to eliminate the bin folder from commit and also lint.xml files but then i am not able to figure out how could i set a different commit message to every file i commit? I had a look at gitk and it is very useful in understanding the current scenario.

Here is what I do :-

Fork your repo->make changes and add to git->included the files i donot want to commit in .gitignore->write the commit msg and then push it.

The diff file is also attached with this mail incase you wanna have a look at it.How could i convert it to a patch so that it would be very easy then for you to just merge it with your code.

As far as apk file is concerned I have attached it with this mail.Please see through it what changes I need to do.

Yours Sincerely,

Shalin Shah 

[aap]

Hi Shalin,

It doesn't look like you have pushed your commit to github. Patch files are not required -- nothing is easier to merge than a well formed commit on github. That also has the advantage of your git username being associated with the commit in our commit history.

Looks like you do still have some whitespace changes mixed in, in onActivityResult.

For reviewing the actual functionality you changed I will have to defer to other developers here -- as I said, I am not really involved with OI Flashlight.

-- Aaron

[Shalin Shah]

Sir,

              I have now commited only the required files nad no extra file but i am not able to push on github error is authentication failed and i also serached on google it says it is a bug. Now is there any way i could submit you my code ?

Yours Sincerely,

Shalin Shah

[Friedger Müffke]

Is this a temporary thing? Could you commit it to a new repository?

I haven't understood the error, problem. Do you have references?

Cheers

Friedger

2013/2/3 Shalin Shah <shalins...@gmail.com>

Yours Sincerely,

Shalin Shah

--

[Shalin Shah]

Sir, 

                 I was not able to submit my modified code on git directory because of this bug which simply said error : authentication failed when i entered my id and password.Now as per your suggestion I created a new repo  and tried it but it still did'nt work but fortunately when I did the same thing from different os I was able to push it to git.:)

                 Now the only thing is I have commited some whitespaces also is there any way to remove that from my commit.Please have a look at commits: https://github.com/shalinshah1993/flashlight/commit/fd55a2e6acc87ee87b1b63f5e7b779318ebaaf07 .Also .apk is attached in case you want to test it and want to make me change something.

Yours Sincerely,

Shalin Shah

[Shalin Shah]

Sir,

        I have sent a pull request please have a look at it.

-- 
Yours Sincerely,

Shalin Shah

[Shalin Shah]

Respected SIr,

             I sent a pull request how would I know if have merged my branch with the master or not and if not what improvements should I make to ensure that you will merge it with master branch?

[aap]

Hi Shalin,

Lacking evidence to the contrary, I assume Friedger has been too busy to look at it. 

If it is accepted, you will see your commits on the master branch of the repo you forked from.

If there are issues, you will get email notifications as comments are added to the pull request and/or the code.

-- Aaron

[Shalin Shah]

thank-you aaron sir for your response I assume now I should probably start working on other app.

[Friedger Müffke]

I don't want to be the bottle neck but can't help. If you would like to have more permissions etc. let's talk.

--

[Shalin Shah]

Sir,

        I am sorry I know you are very busy but if you could merge my code with the master then it would be great.

Yours Sincerely,

Shalin Shah

[aap]

Hi Shalin,

Earlier you asked about how to remove the whitespace changes from your commits. (You also still have an Eclipse settings file.) This page could be useful reading. Also the linked best practices page is also worth a look.

Hi Friedger,

I could perhaps review the code but probably you should express an opinion on the permissions added. 

If you are entertaining the idea of giving Shalin commit rights to OI Flashlight-- and just to be clear, I don't object-- then it's probably time to give George commit rights for OI File Manager. If you agree, I can arrange it, or of course you could do it yourself if you prefer.

-- Aaron

[Friedger Müffke]

Did I missed that? What permissions?

I have merged the pull request.

Cheers

Friedger

2013/2/10 aap <aa...@peromsik.net>

[aap]

Looks like a false alarm, confused by whitespace changes. Perhaps the only real change is related to the widget, which seems reasonable.

-- Aaron

[Shalin Shah]

Thank-you very much for showing a response for my work Aaroon Sir & Friedger Sir I am very happy that you added me to the list of contributors.I will not let you down.

Aaron sir have you tried going to random color mode I have made the color change smoother & not only that just give a long click on the Screen in this changing mode and then it will stop & again on long click it starts.And the freq setter is also for this random color change mode.If you could suggest me some changes or improvements please do so I will do that.


Yours Sincerely,
Shalin Shah