PATCH 1 of 1] correctly check return value of nice()

3 views
Skip to first unread message

Lee Duncan

unread,
May 21, 2013, 5:16:38 PM5/21/13
to open-...@googlegroups.com
The nice() call can return a negative value, since
it returns the previous nice value.

Signed-off-by: Lee Duncan <leeman...@gmail.com>
---
usr/iscsi_util.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/usr/iscsi_util.c b/usr/iscsi_util.c
index 5e3420e..ac86847 100644
--- a/usr/iscsi_util.c
+++ b/usr/iscsi_util.c
@@ -60,7 +60,8 @@ int oom_adjust(void)
char path[ISCSI_OOM_PATH_LEN];
struct stat statb;

- if (nice(-10) < 0)
+ errno = 0;
+ if (nice(-10) == -1 && errno != 0)
log_debug(1, "Could not increase process priority: %s",
strerror(errno));

--
1.7.10.4

Mike Christie

unread,
May 28, 2013, 4:21:27 AM5/28/13
to open-...@googlegroups.com, Lee Duncan
Merged in commit fdac3904c36f2d0bf0a096d533e483ec3be004d2
Reply all
Reply to author
Forward
0 new messages