open-iscsi looks broken on 2.6.27-rc4
Erez Zilber
wasn't able to build the open-iscsi tree, so I added the following
patch:
diff --git a/kernel/Makefile b/kernel/Makefile
index 139fd7b..7c5b5ac 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -101,6 +101,8 @@ linux_2_6_25: has_24_patch
linux_2_6_26: $(unpatch_code)
+linux_2_6_27: $(unpatch_code)
+
do_unpatch_code:
echo "Un-patching source code for use with linux-2.6.14 and up ..."
patch -R -E -p1 < $(cur_patched)
But now, I get compilation errors:
[erez.zilber@klab13:~/work/open-source/open-iscsi]$ make
make -C utils/fwparam_ibft
make[1]: Entering directory
`/home1/erez.zilber/work/open-source/open-iscsi/utils/fwparam_ibft'
cc -O2 -g -fPIC -Wall -Wstrict-prototypes -I../../include -c -o
fwparam_ibft.o fwparam_ibft.c
cc -O2 -g -fPIC -Wall -Wstrict-prototypes -I../../include -c -o
fw_entry.o fw_entry.c
fw_entry.c: In function 'dump_mac':
fw_entry.c:41: warning: unused variable 'i'
cc -O2 -g -fPIC -Wall -Wstrict-prototypes -I../../include -c -o
prom_lex.o prom_lex.c
<stdout>:1622: warning: 'yyunput' defined but not used
cc -O2 -g -fPIC -Wall -Wstrict-prototypes -I../../include -c -o
prom_parse.tab.o prom_parse.tab.c
cc -O2 -g -fPIC -Wall -Wstrict-prototypes -I../../include -c -o
fwparam_ppc.o fwparam_ppc.c
fwparam_ppc.c: In function 'loop_devs':
fwparam_ppc.c:352: warning: passing argument 4 of 'qsort' from
incompatible pointer type
make[1]: Leaving directory
`/home1/erez.zilber/work/open-source/open-iscsi/utils/fwparam_ibft'
make -C usr
make[1]: Entering directory `/home1/erez.zilber/work/open-source/open-iscsi/usr'
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o util.o util.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o io.o io.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o auth.o auth.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o login.o login.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o log.o log.c
log.c:325: warning: '__dump_char' defined but not used
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o md5.o md5.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o sha1.o sha1.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o iface.o iface.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o idbm.o idbm.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o sysdeps.o sysdeps.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o sysfs.o sysfs.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o iscsi_sysfs.o iscsi_sysfs.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o netlink.o netlink.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o initiator.o initiator.c
initiator.c: In function 'session_login_task':
initiator.c:1976: warning: too many arguments for format
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o scsi.o scsi.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o actor.o actor.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o mgmt_ipc.o mgmt_ipc.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o isns.o isns.c
make[1]: Warning: File `transport.c' has modification time 1.7e+02 s
in the future
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o transport.o transport.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o iscsid.o iscsid.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE util.o io.o auth.o login.o log.o md5.o
sha1.o iface.o idbm.o sysdeps.o sysfs.o iscsi_sysfs.o netlink.o
initiator.o scsi.o actor.o mgmt_ipc.o isns.o transport.o iscsid.o -o
iscsid
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o strings.o strings.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o discovery.o discovery.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o iscsiadm.o iscsiadm.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE util.o io.o auth.o login.o log.o md5.o
sha1.o iface.o idbm.o sysdeps.o sysfs.o iscsi_sysfs.o
../utils/fwparam_ibft/fw_entry.o ../utils/fwparam_ibft/fwparam_ibft.o
../utils/fwparam_ibft/fwparam_ppc.o ../utils/fwparam_ibft/prom_lex.o
../utils/fwparam_ibft/prom_parse.tab.o strings.o discovery.o
iscsiadm.o -o iscsiadm
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o iscsistart.o iscsistart.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -c -o statics.o statics.c
cc -O2 -g -Wall -Wstrict-prototypes -I../include -DLinux
-DNETLINK_ISCSI=8 -D_GNU_SOURCE -static netlink.o util.o io.o auth.o
login.o log.o md5.o sha1.o iface.o idbm.o sysdeps.o sysfs.o
iscsi_sysfs.o initiator.o scsi.o actor.o mgmt_ipc.o isns.o transport.o
../utils/fwparam_ibft/fw_entry.o ../utils/fwparam_ibft/fwparam_ibft.o
../utils/fwparam_ibft/fwparam_ppc.o ../utils/fwparam_ibft/prom_lex.o
../utils/fwparam_ibft/prom_parse.tab.o iscsistart.o statics.o -o
iscsistart
login.o: In function `resolve_address':
/home1/erez.zilber/work/open-source/open-iscsi/usr/login.c:168:
warning: Using 'getaddrinfo' in statically linked applications
requires at runtime the shared libraries from the glibc version used
for linking
make[1]: warning: Clock skew detected. Your build may be incomplete.
make[1]: Leaving directory `/home1/erez.zilber/work/open-source/open-iscsi/usr'
make -C kernel
make[1]: Entering directory
`/home1/erez.zilber/work/open-source/open-iscsi/kernel'
make -C /lib/modules/2.6.27-rc4-iscsi-cxgb3i-20080828/build M=`pwd`
KBUILD_OUTPUT= V=0 modules
make[2]: Entering directory
`/home1/erez.zilber/work/kernel.org/linux-2.6-iscsi.git'
CC [M] /home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.o
In file included from
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:30:
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.h:201:
error: 'KOBJ_NAME_LEN' undeclared here (not in a function)
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:
In function 'iscsi_create_endpoint':
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:174:
warning: passing argument 2 of 'class_find_device' from incompatible
pointer type
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:174:
error: too few arguments to function 'class_find_device'
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:
In function 'iscsi_lookup_endpoint':
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:225:
warning: passing argument 2 of 'class_find_device' from incompatible
pointer type
/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:225:
error: too few arguments to function 'class_find_device'
make[3]: *** [/home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.o]
Error 1
make[2]: *** [_module_/home1/erez.zilber/work/open-source/open-iscsi/kernel]
Error 2
make[2]: Leaving directory
`/home1/erez.zilber/work/kernel.org/linux-2.6-iscsi.git'
make[1]: *** [all] Error 2
make[1]: Leaving directory
`/home1/erez.zilber/work/open-source/open-iscsi/kernel'
make: *** [all] Error 2
Mike Christie
> I'm trying to run with the open-iscsi kernel tree (2.6.27-rc4). I
> wasn't able to build the open-iscsi tree, so I added the following
> patch:
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 139fd7b..7c5b5ac 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -101,6 +101,8 @@ linux_2_6_25: has_24_patch
>
> linux_2_6_26: $(unpatch_code)
>
> +linux_2_6_27: $(unpatch_code)
> +
> do_unpatch_code:
> echo "Un-patching source code for use with linux-2.6.14 and up ..."
> patch -R -E -p1 < $(cur_patched)
>
> But now, I get compilation errors:
Yeah, the driver model code in the upstream kernel changed on us again,
so the patches have to be updated.