[PATCH] rm db from open-iscsi take two

[Mike Christie]

Here is a updated db removal patch.

Changes:

1. Use /etc/iscsi for config files instead of /etc/sysconfig
2. Fix single param update bug where all values were getting overwritten
with the default values instead of just updating the one value.
3. Fixed up more logging so instead of the record id being spit out the
target name and portal address is. (still some more log messages to find
and cleanup).
5. Manual target addition should be fixed.

Patch was made over the current svn tree.

[Mike Christie]

Merged with more fixed like added the locking back in and session mode
in 663 and 664. I just need to update the init scripts now.

[Albert Pauw]

Don't think it is a succes.

i) Had to move /etc/initiatorname.iscsi to
/etc/iscsi/initiatorname.iscsi
ii) Had to rediscover the target
iii) After discovery a iscsiadm -m node -r <recid> doesn't work
anymore, and iscsiadm -m node doesn't show the <recid> anymore.

[Mike Christie]

Albert Pauw wrote:
> Don't think it is a succes.
>
> i) Had to move /etc/initiatorname.iscsi to
> /etc/iscsi/initiatorname.iscsi

You also have to move /etc/iscsid.conf to /etc/iscsi/iscsid.conf. I just
udpdated the Makefile to do this.

> ii) Had to rediscover the target
> iii) After discovery a iscsiadm -m node -r <recid> doesn't work
> anymore, and iscsiadm -m node doesn't show the <recid> anymore.

I just updated the README in r667 and iscsiadm --help in r666. It should
now spit out only the target and portal info and you can pass that to
iscsiadm instead of the record id. Well, i mean you have to pass that
now instead of the record id.

To do discovery you can do

./iscsiadm -m discovery -t sendtargets -p 192.168.1.1:3260

as usual.

to login you do:

./iscsiadm -m node -T iqn.2005-03.com.max -p 192.168.0.4:3260 -l

-T is the targetname and -p is the ip address and port like in the
discvery command.

[Albert Pauw]

Thanks,

I go and practice on this ;-)
I guess I used the record ids to long...

Albert

[Albert Pauw]

More work to do now:

1) automatic login mode in initd script don't work anymore

2) regression.sh needs rewriting

[Albert Pauw]

I'll give them a try tomorrow.

[Mike Christie]

Albert Pauw wrote:
> More work to do now:
>
> 1) automatic login mode in initd script don't work anymore
>

Yeah I completely broke the initd scripts. I was in the middle of
reading some bash scripting how tos when I saw this. For the red hat
script instead of doing

iscsiad -m node

and getting the record ids from the output. I was trying to figure out
how to get the targetname and portal info out so it could be used for
the login command.

> 2) regression.sh needs rewriting
>

yeah. on the todo. I suck at scripting so it takes me longer.

[Mike Christie]

Ah ok cool. I will try to work on them. If I get done I get done if not
then hopefully you will :)