Re: How to contribute changes?

[Mike Christie]

On 04/25/2013 06:06 PM, Chris Moore wrote:
> I'm working on adding open-isci support to a driver. How would I go
> about getting changes accepted?

Just post the changes to this list?

We prefer the code in patch format, so you would something like

git diff > some-name.patch

or

git format-patch some args

or

diff -aurp open-iscsi.original open-iscsi.work




> The only thing I'd need to change within open-iscsi is to add a new
> transport to usr/transport.c
>
> Thanks,
>
> Chris
>
> --
> You received this message because you are subscribed to the Google
> Groups "open-iscsi" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to open-iscsi+...@googlegroups.com.
> To post to this group, send email to open-...@googlegroups.com.
> Visit this group at http://groups.google.com/group/open-iscsi?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[Chris Moore]

Sorry for the delayed reply.  Here's the change I'd like to see about getting in:

Thanks,

Chris

diff --git a/usr/transport.c b/usr/transport.c

index e6e3dfc..83483c6 100644

--- a/usr/transport.c

+++ b/usr/transport.c

@@ -97,6 +97,13 @@ struct iscsi_transport_template qla4xxx = {

  .ep_disconnect = ktransport_ep_disconnect,

 };

 

+struct iscsi_transport_template ocs = {

+ .name = "ocs",

+ .ep_connect = ktransport_ep_connect,

+ .ep_poll = ktransport_ep_poll,

+ .ep_disconnect = ktransport_ep_disconnect,

+};

+

 static struct iscsi_transport_template *iscsi_transport_templates[] = {

  &iscsi_tcp,

  &iscsi_iser,

@@ -105,6 +112,7 @@ static struct iscsi_transport_template *iscsi_transport_templates[] = {

  &bnx2i,

  &qla4xxx,

  &be2iscsi,

+ &ocs,

  NULL

 };

[Michael Christie]

Do you have a kernel driver too? Are you going to get that upstream?

I do not care if it closed source or if you are not going to get it upstream. Just wondering what other iscsi hardware is out there. I will merge the patch either way.

Can you say what ocs stands for?

[Chris Moore]

OCS is "One Connect Storage" - Emulex hardware.  The OCS driver is one that we (Emulex) provide as a reference driver to our customers. 

The driver itself is not GPL because some of the customers don't want to be bound by the GPL requirements if they end up using our source, so we're not planning to upstream the driver itself.  But it would be handy to have the user space iscsi tools aware of our driver so the users don't have to patch the openiscsi source to talk to the driver.

Thanks,

Chris

[Ulrich Windl]

>>> Chris Moore <cmoo...@gmail.com> schrieb am 15.05.2013 um 06:32 in Nachricht
<CADO0a1Qh+jRx0ACV=hbqHhxeZ2+e-R=S47Sm4VrU7vaAevmg=A...@mail.gmail.com>:

> OCS is "One Connect Storage" - Emulex hardware. The OCS driver is one that
> we (Emulex) provide as a reference driver to our customers.
>
> The driver itself is not GPL because some of the customers don't want to be
> bound by the GPL requirements if they end up using our source, so we're not
> planning to upstream the driver itself. But it would be handy to have the
> user space iscsi tools aware of our driver so the users don't have to patch
> the openiscsi source to talk to the driver.

On GPL: I wonder what the customers do if everything else in the Linux kernel is GPL; port the driver to another OS? ;-)

[Chris Moore]

I've wondered that myself.  Fortunately I'm not a lawyer, and ultimately I don't distribute the product, so I don't have to deal with it. :-)

I do know there are some that do port to another OS.  Since our boards end up in embedded systems, some of them even roll their own OSes.

I'm also not sure how the whole proprietary driver thing works - for example, I think nVidia has closed drivers for Linux, but they get away with it somehow.

I'd sure the lawyers will have a good time figuring it out.  I just make sure our corporate legal department knows what's going on and leave it up to them.

Chris

[Mike Christie]

Merged in commit 83d31c7bde5503f15623bebc4884fe675f6f4f96

On 05/14/2013 05:48 PM, Chris Moore wrote:
> Sorry for the delayed reply. Here's the change I'd like to see about
> getting in:
>
> Thanks,
>
> Chris
>
>
> diff --git a/usr/transport.c b/usr/transport.c
> index e6e3dfc..83483c6 100644
> --- a/usr/transport.c
> +++ b/usr/transport.c
> @@ -97,6 +97,13 @@ struct iscsi_transport_template qla4xxx = {

> .ep_disconnect= ktransport_ep_disconnect,

> };
>
> +struct iscsi_transport_template ocs = {
> +.name= "ocs",
> +.ep_connect= ktransport_ep_connect,
> +.ep_poll= ktransport_ep_poll,

> +.ep_disconnect= ktransport_ep_disconnect,

> <mailto:open-iscsi%2Bunsu...@googlegroups.com>.

> > To post to this group, send email to open-...@googlegroups.com

> <mailto:open-...@googlegroups.com>.