feature request for onebusaway-nyc: Route List page (desktop and mobile)

43 views
Skip to first unread message

Frumin, Michael

unread,
Feb 7, 2013, 11:33:50 AM2/7/13
to onebusaway...@googlegroups.com

All,

 

I wonder if any has interest in prototyping/developing a feature in the onebusaway-nyc UI’s that, if it works out right, could get released into the live NYC deployment?

 

I’ve taken a stab at the requirements here: https://github.com/camsys/onebusaway-nyc/issues/9

 

If anyone has interest, lemme know and I’m perfectly happy to talk through the need, my ideas, look at prototypes, discuss compromises, etc.

 

Thanks

Mike

Evgeni Makarov

unread,
Feb 8, 2013, 1:35:47 AM2/8/13
to onebusaway...@googlegroups.com
Hi Michael, yes, I wrote you a letter a couple of days ago about ETAs API algorithm description

Kurt Raschke

unread,
Feb 8, 2013, 12:50:22 PM2/8/13
to onebusaway...@googlegroups.com
I have started work on a prototype implementation of Mike's spec here:

https://github.com/kurtraschke/onebusaway-nyc/commits/9-route-list

(desktop UI only for now, mobile UI to follow)

-Kurt
> --
> You received this message because you are subscribed to the Google Groups
> "onebusaway-developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to onebusaway-devel...@googlegroups.com.
> To post to this group, send email to onebusaway...@googlegroups.com.
> Visit this group at
> http://groups.google.com/group/onebusaway-developers?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Frumin, Michael

unread,
Feb 11, 2013, 10:56:27 PM2/11/13
to onebusaway...@googlegroups.com
Kurt, that's awesome, thanks! If you want to send a link (off-list is OK too) for me to look at and give feedback on, I would be happy to check it out.

Thanks,
Mike

Kurt Raschke

unread,
May 20, 2013, 9:08:47 PM5/20/13
to onebusaway...@googlegroups.com
Here are some notes for anyone looking to get this running:

* There is one new CSS file, which is included in the ACTA overlay webapp but will need to be copied and adapted for other branding overlays as needed: onebusaway-nyc-acta-webapp/src/main/webapp/css/routes/routes.css.

* Two new configuration parameters are used: display.showAgencyNames and display.useAgencyId, both of which default to "false", which would be the appropriate setting for the single-agency use case.

You should have no problem pulling and building from the kurtraschke:9-route-list branch; the only existing file which is modified is onebusaway-nyc.properties.

Once running, the desktop version of the route list can be found at <OBA root>/routes, and the mobile version at <OBA root>/m/routes.

-Kurt

Sheldon A. Brown

unread,
May 21, 2013, 10:23:48 AM5/21/13
to onebusaway...@googlegroups.com
Thanks for the reminder Kurt!

I've merged your changes into onebusaway-nyc and I'm trying them out on the dev environment now.  Thanks!

Sheldon

Frumin, Michael

unread,
May 21, 2013, 12:13:15 PM5/21/13
to onebusaway...@googlegroups.com

Kurt, thanks.  We have this deployed in a dev/test environment and it’s looking very snazz!  May I offer a few minor UI/aesthetic suggestions?

 

1.       To be consistent with how a route is displayed in the main OBANYC home page (e.g. http://www.bustime.mta.info/#B61), the name of the route (e.g. “B61 Park Slope – Downtown Brooklyn”) should be black, not blue.

2.       There seems to be extra space between the colored line and the route description (e.g. “via Van Brunt St / Columbia St / 9th St”) – looking at the HTML there’s a <BR> there – is it really needed?

3.       You have the CSS specified such that each <li> gets witdh = 30% (i.e. 3 entries across each row).  This leads to lots of route names and some descriptions wrapping.  I think it’s worth trying with 40-50% so that there’s only 2 entries per row – it will make the page longer but I think make it easier to look at.

 

Thoughts?  If you are to make changes, I guess it should somehow be coordinated with Sheldon since he pulled in your original version into the main branch.

 

Thanks,

Mike

 

 

From: onebusaway...@googlegroups.com [mailto:onebusaway...@googlegroups.com] On Behalf Of Sheldon A. Brown
Sent: Tuesday, May 21, 2013 10:24 AM
To: onebusaway...@googlegroups.com
Subject: Re: [onebusaway-developers] feature request for onebusaway-nyc: Route List page (desktop and mobile)

 

Thanks for the reminder Kurt!

Kurt Raschke

unread,
May 24, 2013, 4:12:07 PM5/24/13
to onebusaway...@googlegroups.com
Mike,

Thanks for the feedback! I've pushed a commit to the 9-route-list branch which fixes these issues.  Assuming I'm not totally confused as to how Git handles such things, if Sheldon pulls and merges the 9-route-list branch again, it should just pick up the new commit.


-Kurt

Frumin, Michael

unread,
Jun 5, 2013, 3:11:43 PM6/5/13
to onebusaway...@googlegroups.com

Kurt,

 

We are almost there, only one final minor improvement request before we can use it: can you please add, in the desktop routes page above the “Routes” text, the same logo+links that are at the top of every wiki page?  i.e.:

 

 

I believe the actual image is incorporated via CSS that pulls in a deployment/branding/overlay-specific image.

 

Before changing the jsp though, please pull down our latest version from https://github.com/camsys/onebusaway-nyc/blob/master/onebusaway-nyc-webapp/src/main/webapp/WEB-INF/content/routes.jspx -- we pulled in your style updates but then added a bit of javascript to get the route ID/name to pick up the color when hovering.

 

Thanks,

Mike

 

From: onebusaway...@googlegroups.com [mailto:onebusaway...@googlegroups.com] On Behalf Of Kurt Raschke
Sent: Friday, May 24, 2013 4:12 PM
To: onebusaway...@googlegroups.com
Subject: Re: [onebusaway-developers] feature request for onebusaway-nyc: Route List page (desktop and mobile)

 

Mike,

--

Kurt Raschke

unread,
Jun 8, 2013, 7:43:51 PM6/8/13
to onebusaway...@googlegroups.com
I've committed a revision which applies the same SiteMesh decorator as is used for wiki pages to the route list.  As long as the intended behavior is to have the exact same styling for the wiki and the route list, this will suffice.

I've also split out the inline JavaScript into a static source file, in keeping with accepted good practice.

-Kurt
image001.png

Frumin, Michael

unread,
Jul 12, 2013, 10:59:06 AM7/12/13
to onebusaway...@googlegroups.com

And it’s live:

-          Desktop: http://bustime.mta.info/routes/

-          Mobile: http://bustime.mta.info/m/routes/

 

Thanks to everyone for their contributions on this simple but useful feature.

Reply all
Reply to author
Forward
0 new messages