Bindings branch fixes: insertObject:inArraySortedByDescriptors: and _indexOfObject:sortedByFunction:context
1 view
Skip to first unread message
Alexander Ljungberg
Nov 20, 2009, 9:42:51 PM11/20/09
to Cappuccino & Objective-J Development List
These changes only relate to the Bindings branch, although they are
found in my 'jakebindings' branch which combines the two. I think they
can be lifted cleanly into bindings with no jake carryover.
CPArray insertObject:inArraySortedByDescriptors: didn't work due to
some typos. Also when given an array like [1, 3, 5] and 2 to insert,
it would produce [2, 1, 3, 5] due to _indexOfObject returning 'mid'
which contained the correct midpoint for the penultimate comparison,
rather than the ultimate comparison. Also fixed a minor thing with
empty arrays.
Commits:
http://github.com/aljungberg/cappuccino/commit/3c29b9a5368340c1ab74bbf1ab6e7150bd380875
http://github.com/aljungberg/cappuccino/commit/2a28eeca7e6d542fc4aa7d70b8f7af6f10b70947
Unit tests included.
Regards,
Alexander
found in my 'jakebindings' branch which combines the two. I think they
can be lifted cleanly into bindings with no jake carryover.
CPArray insertObject:inArraySortedByDescriptors: didn't work due to
some typos. Also when given an array like [1, 3, 5] and 2 to insert,
it would produce [2, 1, 3, 5] due to _indexOfObject returning 'mid'
which contained the correct midpoint for the penultimate comparison,
rather than the ultimate comparison. Also fixed a minor thing with
empty arrays.
Commits:
http://github.com/aljungberg/cappuccino/commit/3c29b9a5368340c1ab74bbf1ab6e7150bd380875
http://github.com/aljungberg/cappuccino/commit/2a28eeca7e6d542fc4aa7d70b8f7af6f10b70947
Unit tests included.
Regards,
Alexander
Reply all
Reply to author
Forward
0 new messages