Gmail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
Multiple frequency channels supported in yans wifi channel and PHY
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
nicoba...@gmail.com  
View profile  
 More options Jul 6, 5:52 am
From: nicoba...@gmail.com
Date: Mon, 06 Jul 2009 09:52:57 +0000
Local: Mon, Jul 6 2009 5:52 am
Subject: Re: Multiple frequency channels supported in yans wifi channel and PHY
I like this implementation in that it is effective in providing
multi-channel support with minimal code modifications. Some detailed
comments below.

http://codereview.appspot.com/91057/diff/1/3
File src/devices/wifi/yans-wifi-phy.cc (right):

http://codereview.appspot.com/91057/diff/1/3#newcode313
Line 313: Simulator::Schedule (m_channelSwitchDelay,
&YansWifiPhy::DoSetChannelId, this, nch);
Good to see that you model the channel switching delay. However, with
this implementation the PHY will be still functional when switching
channel, and also a packet whose transmission will be started just prior
to the execution of the channel switch will still be performed
correctly. In reality, a significant portion of the channel switch time
is due to the oscillator in the RF stage moving to the new frequency.
This will likely disrupt any ongoing TX/RX. I think we should model this
feature, otherwise it does not make sense to model the channel switch
time at all.

http://codereview.appspot.com/91057/diff/1/3#newcode495
Line 495:
It would be good to add also Configure80211gParameters(), which will use
80211a modes but in the 2.4 GHz band.
We might also consider having Configure80211bgParameters(), which would
work in the 2.4 GHz band with both a and b modes.

http://codereview.appspot.com/91057/diff/1/4
File src/devices/wifi/yans-wifi-phy.h (right):

http://codereview.appspot.com/91057/diff/1/4#newcode75
Line 75: *
How do we handle devices which can switch between the 2.4 GHz and the 5
GHz band? Do we need to call Configure80211a/b/g expicitly every time?

http://codereview.appspot.com/91057/diff/1/4#newcode81
Line 81: void SetFrequencyChannel (uint16_t id);
I think the name SetFrequencyChannel() is not very intuitive.
Why not call these "SetChannelNumber()", "GetChannelNumber()" and
"GetChannelFrequencyMHz()"?

Furthermore, I wonder if some of these methods can be moved to
WifiPhy(), so that we can have an interface for handling multiple
channels which is uniform across different WifiPhy impelmentations.

http://codereview.appspot.com/91057/diff/1/4#newcode82
Line 82: /// Return current channel ID, see SetChannelId()
reference to non-existent method SetChannelId()

http://codereview.appspot.com/91057


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "WimaxModule review" by Faker Moatamri
Faker Moatamri  
View profile  
 More options Jul 6, 11:35 am
From: Faker Moatamri <faker.moata...@sophia.inria.fr>
Date: Mon, 06 Jul 2009 17:35:46 +0200
Local: Mon, Jul 6 2009 11:35 am
Subject: WimaxModule review
Hi all,
Please find in this link the complete review of the wimax module. Please
feel free to contact me for an explanation of a comment in the review or
for more details.
Here is the link:
*http://codereview.appspot.com/75057/show
*Best regards
Faker Moatamri
*

*


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google