Integrity to Notify.io

[Andrew Kalek]

Hey, Just wanted to let everyone know that I'm building a notifier for
the CI server Integrity (http://integrityapp.com/) and it can be
found: http://github.com/anlek/integrity-notifyio

I am pretty sure it works, however I believe that Notify.io is down
when it comes to post updates and so I'm waiting till service is back
up.

I'm getting: [Failure instance: Traceback (failure with no frames):
<class 'twisted.web.error.Error'>

[Jeff Lindsay]

Sorry for the lame error. If you'd like you can create a ticket to give a better error:

http://gliderlab.lighthouseapp.com/projects/55825-notifyio/tickets

But the service is up, so I'm assuming there is something wrong in your request (bad API key maybe? missing text field?)

--
Jeff Lindsay
http://progrium.com

[Andrew Kalek]

You're half right, I looked into it more and it seems if I'm not
sending a Content-Type=application/x-www-form-urlencoded I get that
error.
I'm not sure if this is a bug or not thought.

Andrew

On Jul 14, 10:15 pm, Jeff Lindsay <progr...@gmail.com> wrote:
> Sorry for the lame error. If you'd like you can create a ticket to give a
> better error:http://gliderlab.lighthouseapp.com/projects/55825-notifyio/tickets
>
> But the service is up, so I'm assuming there is something wrong in your
> request (bad API key maybe? missing text field?)
>

[Jeff Lindsay]

I'm curious what ContentType you *were* sending. Maybe nothing? Anyway, I'd still make a ticket to give better errors.

First thought was to make that a default content type when none is specified, but that might be too magic. I think the right thing to do is fail with a precise explanation. Thoughts?

-jeff

[Andrew Kalek]

I was sending No headers at all. I think to default it to something
that will make it work, unless you are using the content-type as a
validation or different type of input/output data.

On Jul 14, 11:58 pm, Jeff Lindsay <progr...@gmail.com> wrote:
> I'm curious what ContentType you *were* sending. Maybe nothing? Anyway, I'd
> still make a ticket to give better errors.
>
> First thought was to make that a default content type when none is
> specified, but that might be too magic. I think the right thing to do is
> fail with a precise explanation. Thoughts?
>
> -jeff
>

[Jeff Lindsay]

Sounds ok to me. Anybody else? 

Mind making a ticket for it? :)

[David Reese]

On 7/15/10 12:38 AM, Jeff Lindsay wrote:
> Sounds ok to me. Anybody else?

I am always annoyed when my API calls fail because I've used the wrong
ContentType header -- but i usually think, there *must* be some reason
they're requiring a content-type. If nobody can think of a good reason
(I can't off the top of my head), why not be... liberal in what we accept?

david

[Andrew Kalek]

I've created both tickets.

On Jul 15, 12:38 am, Jeff Lindsay <progr...@gmail.com> wrote:
> Sounds ok to me. Anybody else?
>
> Mind making a ticket for it? :)
>

[Jeff Lindsay]

Yeah, really it bugs me too actually. It's the default behavior of twisted.web that's doing it, not my code. I just haven't run into it very often. Better default sounds reasonable.