patches for FreeBSD

5 views
Skip to first unread message

vanil...@gmail.com

unread,
Jan 3, 2010, 9:38:29 PM1/3/10
to nodejs
Hi:

I make a patch to make node works on FreeBSD,


1: enable sendfile & kqueue on FreeBSD.
2: add GETMEM support for FreeBSD.


this patch can be find

http://vv.fatpipi.com/0001-1-make-sendfile-kqueue-work-on-FreeBSD.patch

Simon Cornelius P Umacob

unread,
Jan 6, 2010, 12:31:20 AM1/6/10
to nod...@googlegroups.com
Cool! I'll be testing this on my FreeBSD box... =)

BTW, is rss and vsize supposed to be in 1024 units? I've submitted a
patch for getmem() some time ago but I haven't received any feedback:

http://gist.github.com/267065

Regards,

[ simon.cpu ]

> --
> You received this message because you are subscribed to the Google Groups "nodejs" group.
> To post to this group, send email to nod...@googlegroups.com.
> To unsubscribe from this group, send email to nodejs+un...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/nodejs?hl=en.
>
>
>
>

Ryan Dahl

unread,
Jan 7, 2010, 2:43:54 AM1/7/10
to nod...@googlegroups.com
- tools/utils.py:
GuessArchitecture is not used by node. Even if, "amd64" is not a
value recognized by v8.

- changes to deps/libev/ev.c and deps/libeio/eio.c:
Needs to be accepted by the upstream author, Marc Lehmann. Please
send the patches to the libev mailing list:
http://lists.schmorp.de/mailman/listinfo/libev

- deps/libev/wscript and deps/libeio/wscript
I will wait until your path is accepted by Marc Lehmann to include these.

- getmem() and wscript
Except for the style, which i fixed, it looks good. I haven't
verified that this works, so I'll take your word for it. Commited in
d22952b. Thanks.

Ryan Dahl

unread,
Jan 7, 2010, 2:46:00 AM1/7/10
to nod...@googlegroups.com
On Tue, Jan 5, 2010 at 9:31 PM, Simon Cornelius P Umacob
<simo...@gmail.com> wrote:
> Cool! I'll be testing this on my FreeBSD box... =)
>
> BTW, is rss and vsize supposed to be in 1024 units?  I've submitted a
> patch for getmem() some time ago but I haven't received any feedback:
>
> http://gist.github.com/267065
>
> Regards,
>
> [ simon.cpu ]

er! I'm sorry! Somehow I completely missed that!

Ryan Dahl

unread,
Jan 7, 2010, 2:47:33 AM1/7/10
to nod...@googlegroups.com
> On Tue, Jan 5, 2010 at 9:31 PM, Simon Cornelius P Umacob <simo...@gmail.com> wrote:
> BTW, is rss and vsize supposed to be in 1024 units?

It should be in bytes

Vanilla Hsu

unread,
Jan 7, 2010, 3:43:10 AM1/7/10
to nod...@googlegroups.com
about 'amd64', it should be 'x64',

if without this patch, v8's scons will generate some error on freebsd/amd64,

check deps/v8/SConstruct line 590 and 591.

2010/1/7 Ryan Dahl <coldre...@gmail.com>:

Reply all
Reply to author
Forward
0 new messages