Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
NPM and Optional Dependencies and Etiquette
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  1 message - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Rob Ashton  
View profile   Translate to Translated (View Original)
 More options Jul 10 2012, 12:05 pm
From: Rob Ashton <robash...@codeofrob.com>
Date: Tue, 10 Jul 2012 18:05:42 +0200
Local: Tues, Jul 10 2012 12:05 pm
Subject: NPM and Optional Dependencies and Etiquette

Hey,

We encountered some fun times with Zombie today, which has dependencies
listed of

  "dependencies": {
    "eventsource": "~0.0.5",
    "html5": "~0.3.8",
    "jsdom": "=0.2.14",
    "mime": "~1.2.5",
    "ms": "~0.1.0",
    "q": "~0.8.4",
    "request": "~2.9.202",
    "tough-cookie": "~0.9.13",
    "ws": "~0.4.14"
  },
  "devDependencies": {
    "coffee-script": "~1.3.1",
    "docco": "~0.3.0",
    "express": "~2.5.9",
    "highlight": "~0.2.2",
    "mocha": "~1.0.3",
    "replay": "~1.5.0",
    "ronn": "~0.3.8"
  },

Great! Now, JsDom has dependencies of

  "dependencies": {
    "htmlparser": "1.x",
    "request": "2.x",
    "cssom": "0.2.x",
    "contextify": "0.1.x"
  },
  "optionalDependencies": {
    "contextify": "0.1.x"
  },

Also Great!

However, Zombie doesn't fully work if contextify isn't available (You can't
fire events because zombie does some patching of jsdom and makes
assumptions about contextify being present)

Now... JsDom is ... not quite right in specifying the contextify in both
places (although the documentation clearly states that the optional
dependencies will overwrite the depedencies so that's not a problem.

The question is... what's the etiquette here? Should I, as a consumer of
Zombie and therefore JsDom be specifying contextify in *my* package.json as
a dev dependency? Or should zombie be specifying it as a dependency because
it won't work without it (even though it's not a direct consumer of that
package).

Just wondering who (if anybody) I should be sending a pull request to

Cheers,

Rob


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »