Problem with circular refs and ".." in the module path.

[Isaac Z. Schlueter]

Kris Zyp found an interesting bug where you can create a chain of
horribly unuseful errors if you have a circular dependency and one of
the modules has ".." in the name.

This patch fixes that.

http://github.com/isaacs/node/commit/a9218670bf276f4559cd0ed88be34fe307c1d5d0

Have fun!
--i

[Ryan Dahl]

It looks like you had a couple more commits on that branch? Can you
squash a bugfix for me? (A test would be really really cool :))

[Isaac Z. Schlueter]

Ack, looks like there are issues.

I added some more extensive tests, and refactored the uri and path
modules to use the same normalization logic, so that nothing is
relying on flaky regexps.

http://gist.github.com/260278

Enjoy.

--i

On Dec 18, 9:55 am, Ryan Dahl <coldredle...@gmail.com> wrote:
> On 12/16/09, Isaac Z. Schlueter <i...@foohack.com> wrote:
>
> > Kris Zyp found an interesting bug where you can create a chain of
> >  horribly unuseful errors if you have a circular dependency and one of
> >  the modules has ".." in the name.
>
> >  This patch fixes that.
>

> >  http://github.com/isaacs/node/commit/a9218670bf276f4559cd0ed88be34fe3...

[Ryan Dahl]

On 12/20/09, Isaac Z. Schlueter <i...@foohack.com> wrote:
> Ack, looks like there are issues.
>
> I added some more extensive tests, and refactored the uri and path
> modules to use the same normalization logic, so that nothing is
> relying on flaky regexps.
>
> http://gist.github.com/260278

The patch includes test/mjsunit/circ-*.js which are not referenced in
any test and include setExports() which hasn't been commited. I
removed those tests. Otherwise looks good. Thanks.

http://github.com/ry/node/commit/4dcdfaf9291a5d6a2ed25b5742151a0de562a4a1