Issue 117 in noda-time: Add serialization for ZonedDateTime (Pull Request)

[noda...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 117 by mj1856: Add serialization for ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

I completed JSON serialization for ZonedDateTime back in April, but it
appears not to have made it into the main source tree. Please merge.

http://code.google.com/r/mj1856-noda-time/

[noda...@googlecode.com]

Updates:
Labels: Milestone-1.0

Comment #1 on issue 117 by malcolm.rowe: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

(No comment was entered for this change.)

[noda...@googlecode.com]

Comment #2 on issue 117 by jonathan.skeet: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

While we quite possibly want to pull it soon (I'll try to take a look over
the weekend), the JSON serialization code isn't part of the main NuGet
release, so we can decouple this from v1.0, unless there are changes in the
patch which affect the main codebase.

[noda...@googlecode.com]

Updates:
Labels: -Type-Defect Type-Enhancement

Comment #3 on issue 117 by malcolm.rowe: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

Good point. There aren't: it's just serialisation code. (The patch is
pretty small, too.)

I'll leave this as 1.0 because I suspect we'll merge it in that timescale,
but good point about the actual release artifacts.

[noda...@googlecode.com]

Updates:
Labels: -Priority-Medium Priority-Low

Comment #4 on issue 117 by malcolm.rowe: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

[noda...@googlecode.com]

Comment #5 on issue 117 by jonathan.skeet: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

Just had a look at this, and there's quite a bit of non-serialization code,
including adding Parse and TryParse to Period. Less sure doing it before
making 1.0 now - will need to look carefully.

[noda...@googlecode.com]

Updates:
Labels: -Milestone-1.0 Milestone-1.0-consider

Comment #7 on issue 117 by malcolm.rowe: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

Not blocking 1.0.0: we can take this any time.

[noda...@googlecode.com]

Updates:
Labels: -Milestone-1.0-consider Milestone-1.1-consider

Comment #8 on issue 117 by jonathan.skeet: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

Bumping to the 1.1-consider milestone as we're unlikely to actually graft
it back onto the 1.0.x branch. Users are likely to just take the latest
version of the JSON APIs - we should try to make them work against the 1.0
release though...

[noda...@googlecode.com]

Updates:
Status: Fixed

Comment #10 on issue 117 by jonathan.skeet: Add serialization for

ZonedDateTime (Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

I didn't end up using Matt's branch, but since implementing
ZonedDateTimePattern we've had support for this.

I'll mark this as fixed, but we'll want to review the format when we
document it along with the rest of the JSON.NET stuff.

Matt, I don't know that what I've done will be compatible with your
original branch. (I can't easily check it now due to airport wifi.) Is this
going to be a problem for you?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[noda...@googlecode.com]

Comment #11 on issue 117 by mj1856: Add serialization for ZonedDateTime
(Pull Request)
http://code.google.com/p/noda-time/issues/detail?id=117

No problem at all. Thanks!