IgnoreCase not working

[Joe]

I use QueryByExample in my application and set IgnoreCase which was
working fine.

But, it seems to have broken when I upgraded from NH 1.2.1 to NH 2.1.

The SQL generated appears to be the same, however, the parameters are
not.

Under NH 1.2.1, if I were to search for a string property with "A",
the parameter sent to the database was actually "a%".
Under NH 2.1, if I search for a string property with "A", the
parameter sent to the database is "A".


Am I missing something. Did this behavior change on purpose?

This is against an Oracle database, using the "Oracle9iDialect" from
2.1

Thanks for any help / pointers!

[Fabio Maulo]

Test case in JIRA please.

I mean... before create a JIRA please be sure of your issue proving it in a failing test.

Thanks

2009/8/19 Joe <junkma...@gmail.com>

--
Fabio Maulo

[Joe]

That's my next step -- just wanted to see if anyone already ran into
this and might know what I'm doing wrong. I'm assuming the problem is
with me and not NH.


For the test case, does it have to fit into the NHibernate.Tests
solution or can I just write a quick console app test that shows the
problem?

--Brian


On Aug 20, 6:34 am, Fabio Maulo <fabioma...@gmail.com> wrote:
> Test case in JIRA please.I mean... before create a JIRA please be sure of

> your issue proving it in a failing test.
> Thanks
>

> 2009/8/19 Joe <junkmail....@gmail.com>

[Fabio Maulo]

Have a look to the "Welcome" message of our JIRA (top left)

2009/8/20 Joe <junkma...@gmail.com>

--
Fabio Maulo

[Saijado]

This Bug should be fixed in Version 2.1.1 I've send a patch to JIRA
some weeks ago. Search in JIRA for "Example" and you should find my
post.

-- Armin

[Armin Landscheidt]

http://nhjira.koah.net/browse/NH-1902

[Joe]

Thanks you guys, I was pulling my hair out!

[Joe]

Oops, I celebrated too soon!
I grabbed the latest build from NH TeamCity and at first it seemed
fixed.


But, there is a problem still with case.

If I set a string property to "C", the parameter generated is "C%",
but it should be "c%" because the where clause is: "WHERE (lower
(this_.description) like ?)"

"C%" is not going to match anything returned by a lower() function.


Armin, did you have this problem??

[Joe]

Based on your tests for NH-1902, then this test should pass, too.


I can't seem to get NHibernate to build and test on my machine. Is
this something you can run??

[Test]
public void TestEnableLikeAndCaseInsensitiveWithMatchmodeAnywhere()
{
using (ISession s = OpenSession())
using (ITransaction t = s.BeginTransaction()) {
Componentizable master = GetMaster("BERN", null, null);
ICriteria crit = s.CreateCriteria(typeof(Componentizable));
Example ex = Example.Create(master).EnableLike
(MatchMode.Anywhere).IgnoreCase();
crit.Add(ex);
IList result = crit.List();
Assert.IsNotNull(result);
Assert.AreEqual(3, result.Count);
t.Commit();

[armin-landscheidt]

If I remember right, it doesn't matter if you write 'C%' or 'c%' but I will check it.

[Joe]

It matters on Oracle database:

select 'X' from dual where lower('ABCDE') like 'A%'

Does not return a row, the like comparison fails.

[armin-landscheidt]

Ok I've tested it on MySQL and MS-SQL and there it doesn't matter. Your Test wokrs on my machine.
It seems, this is an Oracle sepcific thing. Mybe I know how to fix it. Give me a second :-D

[armin-landscheidt]

Puhhh some minutes more then i thought ^^. I think I've found it. Ther ist no lower call for Parameter.
I hope sending fils on groups works.
Here is the Patch for the LikeExpression. But I don't know if it was intended that ther is no lower call.
I will try to send the patch in a short time to JIRA.

[armin-landscheidt]

Now I'm really confused. There is an InsensitiveLikeExpression which allways calls lower.
But it calls 'ilike' for Postgres. But in LikeExpression there is no special call for postgresql.
And the lowercase call for paramters are missing too.

Is this a Bug too?

[Joe]

Thank you for all your work and help on this.

> [lowercaseMissingOnParameters.patch1K ]Index: LikeExpression.cs
> ===================================================================
> --- LikeExpression.cs   (revision 4656)
> +++ LikeExpression.cs   (working copy)
> @@ -69,12 +69,21 @@
>                                         .Add(StringHelper.OpenParen)
>                                         .Add(columns[0])
>                                         .Add(StringHelper.ClosedParen);
> +
> +
> +                               lhs.Add(" like ").Add(dialect.LowercaseFunction)
> +                                       .Add(StringHelper.OpenParen)
> +                                       .AddParameter()
> +                                       .Add(StringHelper.ClosedParen);
> +
>                         }
> -                       else
> +                       else {
>                                 lhs.Add(columns[0]);
> +                               lhs.Add(" like ").AddParameter();
> +                              
> +                       }
>
>                         criteriaQuery.AddUsedTypedValues(GetTypedValues(criteria, criteriaQuery));
> -                       lhs.Add(" like ").AddParameter();
>                         if (escapeChar.HasValue)
>                                 lhs.Add(" escape '" + escapeChar + "'");
>                         return lhs.ToSqlString();