Proposed refactorings - best way to submit?

38 views
Skip to first unread message

Gerke Geurts

unread,
Oct 24, 2012, 8:46:07 AM10/24/12
to nhibernate-...@googlegroups.com
I have refactored part of the custom SQL processing code in the process of trying to get more meaningful error messages for problems with custom/native SQL mappings. A pull request resides at https://github.com/nhibernate/nhibernate-core/pull/161. Should I generate a JIRA ticket as well?

Oskar Berggren

unread,
Oct 24, 2012, 8:53:33 AM10/24/12
to nhibernate-...@googlegroups.com
I would say to always JIRA (release notes are based on this). (Preferably they should be stated as a problem that needs a solution, though for "pure code quality" refactorings one can use the "task-type issue".) Pull request on github is then just one of several possible ways to submit the code.

/Oskar


2012/10/24 Gerke Geurts <gge...@gmail.com>
Reply all
Reply to author
Forward
0 new messages