ToLower and ToUpper inverted in Linq?

[Diego Mijelshon]

These lines from NHibernate.Linq.Functions.StringGenerator caught my attention today while researching http://stackoverflow.com/questions/2598202/does-nhibernate-linq-support-tolower-in-where-clauses:

                if (((method.Name == "ToUpper") || (method.Name == "ToUpperInvariant")))

                {

                    methodName = "lower";

                }

                else

                {

                    methodName = "upper";

                }

Isn't it supposed to be the other way around?

   Diego

[Richard Brown]

It does look a little suspicious.  Shouldn't be hard to create a failing test?

[Diego Mijelshon]

Done, test case and patch created: http://216.121.112.228/browse/NH-2169

   Diego