Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
nhibernate-development
Home
+ new post
About this group
Join this group
Proposed refactorings - best way to submit?
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Gerke Geurts  
View profile  
 More options Oct 24 2012, 8:46 am
From: Gerke Geurts <ggeu...@gmail.com>
Date: Wed, 24 Oct 2012 05:46:07 -0700 (PDT)
Local: Wed, Oct 24 2012 8:46 am
Subject: Proposed refactorings - best way to submit?
Print | Individual message | Show original | Report this message | Find messages by this author

I have refactored part of the custom SQL processing code in the process of
trying to get more meaningful error messages for problems with
custom/native SQL mappings. A pull request resides at
https://github.com/nhibernate/nhibernate-core/pull/161. Should I generate a
JIRA ticket as well?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Oskar Berggren  
View profile  
 More options Oct 24 2012, 8:53 am
From: Oskar Berggren <oskar.bergg...@gmail.com>
Date: Wed, 24 Oct 2012 14:53:33 +0200
Local: Wed, Oct 24 2012 8:53 am
Subject: Re: [nhibernate-development] Proposed refactorings - best way to submit?
Print | Individual message | Show original | Report this message | Find messages by this author

I would say to always JIRA (release notes are based on this). (Preferably
they should be stated as a problem that needs a solution, though for "pure
code quality" refactorings one can use the "task-type issue".) Pull request
on github is then just one of several possible ways to submit the code.

/Oskar

2012/10/24 Gerke Geurts <ggeu...@gmail.com>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google