help us test console layout changes

47 views
Skip to first unread message

Michael Hunger

unread,
Oct 15, 2012, 12:59:23 AM10/15/12
to Neo4j, Neo Community Team
Wes Freeman added syntax highlighting and a dynaminc multiline input-field to the console. Thanks a lot.

Please help us test it at http://rabbithole-test.herokuapp.com before we push it into production.

Cheers

Michael

Javier de la Rosa

unread,
Oct 15, 2012, 2:15:47 AM10/15/12
to ne...@googlegroups.com, Neo Community Team
Nice!

Maybe make the already done queries click-able could be also useful,
in order to repeat a specific quey.
> --
>
>



--
Javier de la Rosa
http://versae.es

Wes Freeman

unread,
Oct 15, 2012, 2:30:57 AM10/15/12
to ne...@googlegroups.com, Neo Community Team
That's a cool idea. Might even be better than having a history to scroll through, which was one of the other things I wanted.

We've already found a couple of minor bugs, by the way, that are already fixed in the pull request:
- The carat doesn't line up with the error when an error is reported
- The generate share doesn't have the right query in it (it has the original query, instead)

Wes

--



Peter Neubauer

unread,
Oct 15, 2012, 3:12:36 AM10/15/12
to Wes Freeman, ne...@googlegroups.com, Neo Community Team
Wes,
this looks very neat, I like! I think the caret lining up is not
playing nice with multiline breaks. Not sure how to fix it, since I
think Cypher is interpreting the query as one line only?

Cheers,

/peter neubauer

G: neubauer.peter
S: peter.neubauer
P: +46 704 106975
L: http://www.linkedin.com/in/neubauer
T: @peterneubauer

Neo4j 1.8 GA - http://www.dzone.com/links/neo4j_18_release_fluent_graph_literacy.html

Wes Freeman

unread,
Oct 15, 2012, 3:29:16 AM10/15/12
to Peter Neubauer, ne...@googlegroups.com, Neo Community Team
It's already fixed, just need to merge the rest of the pull request in. I was stripping out carriage returns from the input before sending because it was double returning in the output. 

So I took out the extra \n in the output and left them in while sending from the input so Cypher could do a nice job with the multline string (it only returns the line with the error):
Inline image 2

Inline image 1

Inline image 3

Wes
image.png
image.png
image.png

Peter Neubauer

unread,
Oct 15, 2012, 3:43:04 AM10/15/12
to ne...@googlegroups.com, Neo Community Team
Beautiful Wes!


Cheers,

/peter neubauer

G:  neubauer.peter
S:  peter.neubauer
P:  +46 704 106975
L:   http://www.linkedin.com/in/neubauer
T:   @peterneubauer

Neo4j 1.8 GA - http://www.dzone.com/links/neo4j_18_release_fluent_graph_literacy.html


--
 
 

image.png
image.png
image.png

Michael Hunger

unread,
Oct 20, 2012, 10:50:02 PM10/20/12
to Neo4j
So Peter merged Wes' PR's and everyone tested the stuff and it works?

Then I can push it to the console tomorrow?

Michael

Am 15.10.2012 um 09:43 schrieb Peter Neubauer:

Beautiful Wes!

Cheers,

/peter neubauer

G:  neubauer.peter
S:  peter.neubauer
P:  +46 704 106975
L:   http://www.linkedin.com/in/neubauer
T:   @peterneubauer

Neo4j 1.8 GA - http://www.dzone.com/links/neo4j_18_release_fluent_graph_literacy.html


On Mon, Oct 15, 2012 at 9:29 AM, Wes Freeman <freem...@gmail.com> wrote:
It's already fixed, just need to merge the rest of the pull request in. I was stripping out carriage returns from the input before sending because it was double returning in the output. 

So I took out the extra \n in the output and left them in while sending from the input so Cypher could do a nice job with the multline string (it only returns the line with the error):
<image.png>

<image.png>

<image.png>

--
 
 


Peter Neubauer

unread,
Oct 21, 2012, 2:40:56 AM10/21/12
to ne...@googlegroups.com
My Android browser is inserting a line break in the editor instead of submitting the query. Anyone else seeing that at

Rabbithole-test.herokuapp.com?

/peter
> --
>  
>  
>

--

Andres Taylor

unread,
Oct 21, 2012, 11:13:08 AM10/21/12
to ne...@googlegroups.com

+1

--
 
 
Reply all
Reply to author
Forward
0 new messages