Native-Client-Reviews Google Group

Re: Fix driver test of default translate options on ARM: temporarily not using default (issue 15393003)

commit-...@chromium.org — Sat, 18 May 2013 04:33:36 UT

Change committed as 11365

[link]

Re: Move PNaCl driver tests from trusted env to untrusted env (issue 15268006)

jvo...@chromium.org — Sat, 18 May 2013 04:20:54 UT

LGTM

[link]
File pnacl/driver/tests/nacl.scons (right):

[link]
pnacl/driver/tests/nacl.scons: 9: if 'TRUSTED_ENV' not in env or not
env.Bit('bitcode'):

Re: Fix driver test of default translate options on ARM: temporarily not using default (issue 15393003)

commit-...@chromium.org — Sat, 18 May 2013 02:30:36 UT

CQ is trying da patch. Follow status at
[link]

[link]

Re: [nacltoons] Build third_party libraries into single libdir. (issue 15268005)

s...@chromium.org — Sat, 18 May 2013 01:49:05 UT

Committed patchset #1 manually as r1551 (presubmit successful).

[link]

Move PNaCl driver tests from trusted env to untrusted env (issue 15268006)

dsch...@chromium.org — Sat, 18 May 2013 01:48:06 UT

Reviewers: jvoung (cr),

Message:
The driver tests seemed to work even with --mode=host-dbg,nacl although
none of
the bots will it that way with this change.

Description:
Move PNaCl driver tests from trusted env to untrusted env
This will prevent them from being skipped on the toolchain bots.

[nacltoons] Build third_party libraries into single libdir. (issue 15268005)

s...@chromium.org — Sat, 18 May 2013 01:43:57 UT

Reviewers: binji,

Message:
Hopefully this will make the tree green again.

Description:
[nacltoons] Build third_party libraries into single libdir.

Also, make sure this libdir comes before the naclports
one as we want to use liblua from the cocos build rather
than the one that ships with ports.

Re: Fix driver test of default translate options on ARM: temporarily not using default (issue 15393003)

dsch...@google.com (Derek Schuff) — Sat, 18 May 2013 01:30:35 UT

yes, that's exactly it. I think it's a build.scons because it wants to get
the optimization level which doesn't seem to be immediately available in
the nacl env. I'm playing with making it a nacl.scons

Re: Fix driver test of default translate options on ARM: temporarily not using default (issue 15393003)

jvo...@chromium.org (Jan Voung) — Sat, 18 May 2013 01:28:48 UT

I think it's because the driver scons file is a "build.scons" instead of
"nacl.scons" and all of our PNaCl bots started up skipping trusted tests?

Re: Fix driver test of default translate options on ARM: temporarily not using default (issue 15393003)

dsch...@chromium.org — Sat, 18 May 2013 01:22:26 UT

LGTM
I had just noticed the failure and the strange fact that we are not running
the
driver tests on the toolchain bots, and not even on the pnacl bots, but
only by
accident on the other ARM bots. I'm looking into that currently...

[link]