Fixes for blank componentPath and HttpAntRunner

[Daryl Banttari]

Hi again,

Had to implement a couple of fixes for our environment (where we have
a blank componentPath.)

1. In DirectoryTestSuite.formatTestPath(), I added a CFIF to ensure we
don't concat a period to the beginning if componentPath is blank:

<cfif len(componentPath)>
<cfset formatted = componentPath & "." & formatted>
</cfif>

2. JUnitXMLTestResult.genProps() doesn't always properly escape XML.
Please use xmlFormat() instead of only escaping ampersands for the
value attribute. (We had double quotes sneaking in.) (Might not be
bad to also xmlFormat the property names.)

3. We also added a cfsetting requestTimeout to the top of
HttpAntRunner.run(), but that's an enhancement suggestion, not a bug.

Thanks,

--Daryl

[bill shelton]

Excellent, Daryl. Thank you very much for the contribution! These have
been recorded as issues ...

bill

[Ilyas Patel]

For item 3, to increase the timeout I have implemented this in the ANT
target:

<mxunittask .....
defaultRunner="HttpAntRunner.cfc?
requesttimeout=3000&amp;method=run&amp;"
.....
>

Seems to work a treat.

Ilyas

[Peter J. Farrell]

FYI, not all CFML engines support this behavoir. It would be much
better if the ANT task supported it directly with the runner on the flip
side allowing you to set it via <cfsetting>.

.pjf

Ilyas Patel said the following on 09/16/2009 09:24 AM: