Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Issue 491 in msysgit: Multiple errors when installing msysgit with a Windows user name that has non-ASCII characters

Received: by 10.50.217.193 with SMTP id pa1mr978782igc.1.1334836316580;
        Thu, 19 Apr 2012 04:51:56 -0700 (PDT)
X-BeenThere: msysgit@googlegroups.com
Received: by 10.50.217.197 with SMTP id pa5ls7292090igc.4.canary; Thu, 19 Apr
 2012 04:51:54 -0700 (PDT)
Received: by 10.42.142.202 with SMTP id t10mr910955icu.4.1334836314925;
        Thu, 19 Apr 2012 04:51:54 -0700 (PDT)
Received: by 10.50.151.242 with SMTP id ut18msigb;
        Thu, 19 Apr 2012 04:35:10 -0700 (PDT)
Received: by 10.42.110.75 with SMTP id o11mr963449icp.6.1334835310422;
        Thu, 19 Apr 2012 04:35:10 -0700 (PDT)
Received: by 10.42.110.75 with SMTP id o11mr963446icp.6.1334835310395;
        Thu, 19 Apr 2012 04:35:10 -0700 (PDT)
Return-Path: <ajrie...@gmail.com>
Received: from mail-iy0-f171.google.com (mail-iy0-f171.google.com [209.85.210.171])
        by gmr-mx.google.com with ESMTPS id wf3si1183405igb.3.2012.04.19.04.35.10
        (version=TLSv1/SSLv3 cipher=OTHER);
        Thu, 19 Apr 2012 04:35:10 -0700 (PDT)
Received-SPF: pass (google.com: domain of ajrie...@gmail.com designates 209.85.210.171 as permitted sender) client-ip=209.85.210.171;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ajrie...@gmail.com designates 209.85.210.171 as permitted sender) smtp.mail=ajrie...@gmail.com; dkim=pass header...@gmail.com
Received: by iadj38 with SMTP id j38so14771876iad.30
        for <msysgit@googlegroups.com>; Thu, 19 Apr 2012 04:35:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=c3Eg/IjdKHErpco3c1I/5O/ZDpcJJxwcEFIVM6zkNoQ=;
        b=UOFbDv5niBBGPXbepEac6gnlCfEhlwSo5DqCtqJ/R+KO4ovJU9d6dq7lmWDM8RbJJ6
         fbR0Icg8jqfZw2MOc7MXPCVP4oj7PxuhNw+wsxGq199FEsjoMitCzw1lVy5lkoOfR+bf
         jtgp7JzLiYcIv6hgSNTrtivSoZ566wvK44lgjsYTR+2ks0SFVVsEp35uOVv87Z9/5sIs
         e9EUoEWvpLVbqPeN7dQCJyyBJ9g6oSYq44KIxnhictEFaPpk9UVGg+R7DIxGOk6s2DgV
         VKBQXG0YA6l7ROH/Tuq6D4u18WRtI/icdPDewsyRN4KANKTQ88I9UPiZn8D9IKGs4Pcf
         uCzA==
MIME-Version: 1.0
Received: by 10.50.88.165 with SMTP id bh5mr4175772igb.10.1334835310230; Thu,
 19 Apr 2012 04:35:10 -0700 (PDT)
Received: by 10.64.148.99 with HTTP; Thu, 19 Apr 2012 04:35:10 -0700 (PDT)
In-Reply-To: <CABNJ2G+vAyxg2qzE2b9Yp6tWB2N7-Wjbv=z9W3BPS6-Y-Vm...@mail.gmail.com>
References: <10-3335958013325811970-15440221726816312720-msysgit=googlecode....@googlecode.com>
	<OFF1F1CB4C.0B5D9A20-ONC12579E2.005082F1-C12579E2.00536...@dcon.de>
	<CAKqjTbSUgiwhWRRNtdjYj26xYpf6rRpzEh8qphN3VTWA7aF...@mail.gmail.com>
	<CABNJ2G+vAyxg2qzE2b9Yp6tWB2N7-Wjbv=z9W3BPS6-Y-Vm...@mail.gmail.com>
Date: Thu, 19 Apr 2012 13:35:10 +0200
Message-ID: <CAKqjTbRZrufccf3TVDyKEbSB6m4yvR6J0i+YkfmnCLFRUq0...@mail.gmail.com>
Subject: Re: [msysGit] Re: Issue 491 in msysgit: Multiple errors when
 installing msysgit with a Windows user name that has non-ASCII characters
From: =?ISO-8859-1?Q?=C1ngel_Jos=E9_Riesgo?= <ajrie...@gmail.com>
To: Pat Thoyts <pattho...@gmail.com>
Cc: msysgit@googlegroups.com
Content-Type: multipart/alternative; boundary=e89a8f3ba1597ffb6004be069044

--e89a8f3ba1597ffb6004be069044
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 19, 2012 at 12:21 PM, Pat Thoyts <pattho...@gmail.com> wrote:

> 2012/4/19 =C3=81ngel Jos=C3=A9 Riesgo <ajrie...@gmail.com>:
> >
> > I've found that this problem of supporting extended characters in the
> local
> > code page but not Unicode characters in general also affects the commit
> > message edit field when I reopen the Git Gui application. I can type
> Chinese
> > or Arabic there, but the message I had when I previously closed the
> > application ("=E6=88=91=E5=BE=88=E9=AB=98=E5=85=B4 =D8=A7=D9=86=D8=A7 =
=D9=85=D8=B3=D8=B1=D9=88=D8=B1 =D8=AE=D8=AF=D8=A7 =C2=A1Ahora s=C3=AD...!")=
 hasn't been restored
> > correctly. Whe re-opening the application it is retrieved as "????????
> ?????
> > ???=C2=A1Ahora s=C3=AD...!".
> >
> > It appears as if the Unicode text is being transformed into the local
> code
> > page encoding (ISO-8859-1, I suppose) at some point, which would explai=
n
> why
> > the Arabic and Chinese parts get mangled.
>
> If you type in a commit message and exit git gui, it saves that
> messsage to .git/GITGUI_MSG so you don't have to re-enter the message
> next time. However, the code for this does not specify the encoding of
> this file so it will default to the current system encoding which can
> fail to correctly handle unicode strings. The following patch should
> sort this out for you.
>
>
> From 207b7dbf6c94adcaba46b6af1bb515a23dce3927 Mon Sep 17 00:00:00 2001
> From: Pat Thoyts <pattho...@users.sourceforge.net>
> Date: Thu, 19 Apr 2012 11:19:58 +0100
> Subject: [PATCH] git-gui: preserve commit messages in utf-8
> MIME-Version: 1.0
> Content-Type: text/plain; charset=3DUTF-8
> Content-Transfer-Encoding: 8bit
>
> The commit message buffer is automatically preserved to a local file
> but this uses the system encoding which may fail to properly encode
> unicode text. Forcing this file to use utf-8 preserves the message
> correctly.
>
> Reported-by: =C3=81ngel Jos=C3=A9 Riesgo <ajrie...@gmail.com>
> Signed-off-by: Pat Thoyts <pattho...@users.sourceforge.net>
> ---
>  git-gui.sh |   11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index ba4e5c1..2360cb1 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -1463,7 +1463,7 @@ proc rescan {after {honor_trustmtime 1}} {
>                (![$ui_comm edit modified]
>                || [string trim [$ui_comm get 0.0 end]] eq {})} {
>                if {[string match amend* $commit_type]} {
> -               } elseif {[load_message GITGUI_MSG]} {
> +               } elseif {[load_message GITGUI_MSG utf-8]} {
>                } elseif {[run_prepare_commit_msg_hook]} {
>                } elseif {[load_message MERGE_MSG]} {
>                } elseif {[load_message SQUASH_MSG]} {
> @@ -1549,7 +1549,7 @@ proc rescan_stage2 {fd after} {
>        fileevent $fd_lo readable [list read_ls_others $fd_lo $after]
>  }
>
> -proc load_message {file} {
> +proc load_message {file {encoding {}}} {
>        global ui_comm
>
>        set f [gitdir $file]
> @@ -1558,6 +1558,9 @@ proc load_message {file} {
>                        return 0
>                }
>                fconfigure $fd -eofchar {}
> +               if {$encoding ne {}} {
> +                       fconfigure $fd -encoding $encoding
> +               }
>                set content [string trim [read $fd]]
>                close $fd
>                regsub -all -line {[ \r\t]+$} $content {} content
> @@ -2266,6 +2269,7 @@ proc do_quit {{rc {1}}} {
>                                && $msg ne {}} {
>                                catch {
>                                        set fd [open $save w]
> +                                       fconfigure $fd -encoding utf-8
>                                        puts -nonewline $fd $msg
>                                        close $fd
>                                }
> @@ -3835,7 +3839,7 @@ if {[is_enabled transport]} {
>  }
>
>  if {[winfo exists $ui_comm]} {
> -       set GITGUI_BCK_exists [load_message GITGUI_BCK]
> +       set GITGUI_BCK_exists [load_message GITGUI_BCK utf-8]
>
>        # -- If both our backup and message files exist use the
>        #    newer of the two files to initialize the buffer.
> @@ -3872,6 +3876,7 @@ if {[winfo exists $ui_comm]} {
>                        } elseif {$m} {
>                                catch {
>                                        set fd [open [gitdir GITGUI_BCK] w=
]
> +                                       fconfigure $fd -encoding utf-8
>                                        puts -nonewline $fd $msg
>                                        close $fd
>                                        set GITGUI_BCK_exists 1
> --
> 1.7.10.msysgit.1
>

Well, that was quick! Thanks for the patch. It's not a very serious
problem, and since I type all my commit messages in English (or
occasionally Spanish) I don't really need this functionality right now. I
simply wanted to let you guys know about these issues, just to help the
development. The lack of support for Unicode file names in Git for Windows
gave me problems in the past and I think Git should handle Unicode
smoothly, so I've performed these nasty tests mixing Chinese, Arabic and
Spanish accented letters just to check if msysgit is able to handle Unicode
correctly now or if there were still any problems left.

That problem with the saved commit message has been the only problem
regarding Unicode support that I've found with the latest version of
msysgit. With your patch that fixes this, everything should be working fine
with Unicode paths and commit messages now. Thanks for the great work.

--e89a8f3ba1597ffb6004be069044
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Thu, Apr 19, 2012 at 12:21 PM, Pat Thoyts <sp=
an dir=3D"ltr">&lt;<a href=3D"mailto:pattho...@gmail.com">pattho...@gmail.c=
om</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"marg=
in:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2012/4/19 =C3=81ngel Jos=C3=A9 Riesgo &lt;<a href=3D"mailto:ajriesgo@gmail.=
com">ajrie...@gmail.com</a>&gt;:<br>
<div class=3D"im">&gt;<br>
&gt; I&#39;ve found that this problem of supporting extended characters in =
the local<br>
&gt; code page but not Unicode characters in general also affects the commi=
t<br>
&gt; message edit field when I reopen the Git Gui application. I can type C=
hinese<br>
&gt; or Arabic there, but the message I had when I previously closed the<br=
>
&gt; application (&quot;=E6=88=91=E5=BE=88=E9=AB=98=E5=85=B4 =D8=A7=D9=86=
=D8=A7 =D9=85=D8=B3=D8=B1=D9=88=D8=B1 =D8=AE=D8=AF=D8=A7 =C2=A1Ahora s=C3=
=AD...!&quot;) hasn&#39;t been restored<br>
&gt; correctly. Whe re-opening the application it is retrieved as &quot;???=
????? ?????<br>
&gt; ???=C2=A1Ahora s=C3=AD...!&quot;.<br>
&gt;<br>
&gt; It appears as if the Unicode text is being transformed into the local =
code<br>
&gt; page encoding (ISO-8859-1, I suppose) at some point, which would expla=
in why<br>
&gt; the Arabic and Chinese parts get mangled.<br>
<br>
</div>If you type in a commit message and exit git gui, it saves that<br>
messsage to .git/GITGUI_MSG so you don&#39;t have to re-enter the message<b=
r>
next time. However, the code for this does not specify the encoding of<br>
this file so it will default to the current system encoding which can<br>
fail to correctly handle unicode strings. The following patch should<br>
sort this out for you.<br>
<br>
<br>
From 207b7dbf6c94adcaba46b6af1bb515a23dce3927 Mon Sep 17 00:00:00 2001<br>
From: Pat Thoyts &lt;<a href=3D"mailto:pattho...@users.sourceforge.net">pat=
tho...@users.sourceforge.net</a>&gt;<br>
Date: Thu, 19 Apr 2012 11:19:58 +0100<br>
Subject: [PATCH] git-gui: preserve commit messages in utf-8<br>
MIME-Version: 1.0<br>
Content-Type: text/plain; charset=3DUTF-8<br>
Content-Transfer-Encoding: 8bit<br>
<br>
The commit message buffer is automatically preserved to a local file<br>
but this uses the system encoding which may fail to properly encode<br>
unicode text. Forcing this file to use utf-8 preserves the message<br>
correctly.<br>
<br>
Reported-by: =C3=81ngel Jos=C3=A9 Riesgo &lt;<a href=3D"mailto:ajriesgo@gma=
il.com">ajrie...@gmail.com</a>&gt;<br>
Signed-off-by: Pat Thoyts &lt;<a href=3D"mailto:pattho...@users.sourceforge=
.net">pattho...@users.sourceforge.net</a>&gt;<br>
---<br>
=C2=A0git-gui.sh | =C2=A0 11 ++++++++---<br>
=C2=A01 file changed, 8 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/git-gui.sh b/git-gui.sh<br>
index ba4e5c1..2360cb1 100755<br>
--- a/git-gui.sh<br>
+++ b/git-gui.sh<br>
@@ -1463,7 +1463,7 @@ proc rescan {after {honor_trustmtime 1}} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(![$ui_comm edit mo=
dified]<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|| [string trim [$u=
i_comm get 0.0 end]] eq {})} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if {[string match a=
mend* $commit_type]} {<br>
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } elseif {[load_message =
GITGUI_MSG]} {<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } elseif {[load_message =
GITGUI_MSG utf-8]} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} elseif {[run_prep=
are_commit_msg_hook]} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} elseif {[load_mes=
sage MERGE_MSG]} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} elseif {[load_mes=
sage SQUASH_MSG]} {<br>
@@ -1549,7 +1549,7 @@ proc rescan_stage2 {fd after} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0fileevent $fd_lo readable [list read_ls_others =
$fd_lo $after]<br>
=C2=A0}<br>
<br>
-proc load_message {file} {<br>
+proc load_message {file {encoding {}}} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0global ui_comm<br>
<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0set f [gitdir $file]<br>
@@ -1558,6 +1558,9 @@ proc load_message {file} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0return 0<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fconfigure $fd -eof=
char {}<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if {$encoding ne {}} {<b=
r>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 fconfigure $fd -encoding $encoding<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0set content [string=
 trim [read $fd]]<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0close $fd<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0regsub -all -line {=
[ \r\t]+$} $content {} content<br>
@@ -2266,6 +2269,7 @@ proc do_quit {{rc {1}}} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&amp;&amp; $msg ne {}} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0catch {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0set fd [o=
pen $save w]<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fconfigure $fd =
-encoding utf-8<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0puts -non=
ewline $fd $msg<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0close $fd=
<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
@@ -3835,7 +3839,7 @@ if {[is_enabled transport]} {<br>
=C2=A0}<br>
<br>
=C2=A0if {[winfo exists $ui_comm]} {<br>
- =C2=A0 =C2=A0 =C2=A0 set GITGUI_BCK_exists [load_message GITGUI_BCK]<br>
+ =C2=A0 =C2=A0 =C2=A0 set GITGUI_BCK_exists [load_message GITGUI_BCK utf-8=
]<br>
<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0# -- If both our backup and message files exist=
 use the<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0# =C2=A0 =C2=A0newer of the two files to initia=
lize the buffer.<br>
@@ -3872,6 +3876,7 @@ if {[winfo exists $ui_comm]} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0} elseif {$m} {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0catch {<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0set fd [o=
pen [gitdir GITGUI_BCK] w]<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fconfigure $fd =
-encoding utf-8<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0puts -non=
ewline $fd $msg<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0close $fd=
<br>
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0set GITGU=
I_BCK_exists 1<br>
<span class=3D"HOEnZb"><font color=3D"#888888">--<br>
1.7.10.msysgit.1<br>
</font></span></blockquote></div><div><br></div>Well, that was quick! Thank=
s for the patch. It&#39;s not a very serious problem, and since I type all =
my commit messages in English (or occasionally Spanish) I don&#39;t really =
need this functionality right now. I simply wanted to let you guys know abo=
ut these issues, just to help the development. The lack of support for Unic=
ode file names in Git for Windows gave me problems in the past and I think =
Git should handle Unicode smoothly, so I&#39;ve performed these nasty tests=
 mixing Chinese, Arabic and Spanish accented letters just to check if msysg=
it is able to handle Unicode correctly now or if there were still any probl=
ems left.<div>
<br></div><div>That problem with the saved commit message has been the only=
 problem regarding Unicode support that I&#39;ve found with the latest vers=
ion of msysgit. With your patch that fixes this, everything should be worki=
ng fine with Unicode paths and commit messages now. Thanks for the great wo=
rk.</div>

--e89a8f3ba1597ffb6004be069044--