[PATCH] git-gui: fix usage of themed widgets variable

1 view
Skip to first unread message

Heiko Voigt

unread,
Feb 20, 2010, 1:01:15 PM2/20/10
to Shawn O. Pearce, Pat Thoyts, Johannes Schindelin, g...@vger.kernel.org, msysGit Mailinglist
There was one forgotten global so NS was not visible to the method
which resulted in an error.

Signed-off-by: Heiko Voigt <hvo...@hvoigt.net>
---
git-gui/lib/status_bar.tcl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
}

constructor two_line {path} {
+ global NS
set w $path
set w_l $w.l
set w_c $w.c
--
1.7.0.m5.rc2.13.g7abfa.dirty

Pat Thoyts

unread,
Feb 20, 2010, 1:47:12 PM2/20/10
to Heiko Voigt, Shawn O. Pearce, Johannes Schindelin, g...@vger.kernel.org, msysGit Mailinglist

The commit message should mention what triggered the error I think -
but this patch is clearly correct.
You can have a

Signed-off-by: Pat Thoyts <patt...@users.sourceforge.net>

if you like :)

Pat Thoyts.

Heiko Voigt

unread,
Feb 20, 2010, 1:57:57 PM2/20/10
to Pat Thoyts, Shawn O. Pearce, Johannes Schindelin, g...@vger.kernel.org, msysGit Mailinglist
There was one forgotten global so NS was not visible to the method
which resulted in an error.

The error was triggered by using git gui to clone a local repository.

Signed-off-by: Heiko Voigt <hvo...@hvoigt.net>
Signed-off-by: Pat Thoyts <patt...@users.sourceforge.net>
---


On Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:
> On 20 February 2010 18:01, Heiko Voigt <hvo...@hvoigt.net> wrote:
> > There was one forgotten global so NS was not visible to the method
> > which resulted in an error.
> >
> > Signed-off-by: Heiko Voigt <hvo...@hvoigt.net>

[...]


>
> The commit message should mention what triggered the error I think -
> but this patch is clearly correct.
> You can have a
>
> Signed-off-by: Pat Thoyts <patt...@users.sourceforge.net>
>
> if you like :)

Thanks, taken.

Reply all
Reply to author
Forward
0 new messages