Issue 146 in mp4v2: JPEG image type checking is too strict; EXIF is not interpreted as JPEG (itmf/type.cpp)

[mp...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 146 by honeycom...@gmail.com: JPEG image type checking is too
strict; EXIF is not interpreted as JPEG (itmf/type.cpp)
http://code.google.com/p/mp4v2/issues/detail?id=146

In the IMAGE_HEADERS[] array, JPEG is assumed to be in JFIF container with
APP1 marker "\xff\xe0".
However, since EXIF uses different APP1 marker "\xff\xe1", EXIF file is not
interpreted as JPEG file.

[mp...@googlecode.com]

Updates:
Status: Accepted

Comment #1 on issue 146 by kid...@gmail.com: JPEG image type checking is

too strict; EXIF is not interpreted as JPEG (itmf/type.cpp)
http://code.google.com/p/mp4v2/issues/detail?id=146

could you give me a file to test with?

[mp...@googlecode.com]

Comment #2 on issue 146 by honeycom...@gmail.com: JPEG image type checking

is too strict; EXIF is not interpreted as JPEG (itmf/type.cpp)
http://code.google.com/p/mp4v2/issues/detail?id=146

You can grab some at http://www.exif.org/samples.html

[mp...@googlecode.com]

Updates:
Owner: kid...@gmail.com

Comment #3 on issue 146 by kid...@gmail.com: JPEG image type checking is

too strict; EXIF is not interpreted as JPEG (itmf/type.cpp)
http://code.google.com/p/mp4v2/issues/detail?id=146

I think I understand the issue somewhat; you wouldn't happen to have a
patch I could look at more closely?

[mp...@googlecode.com]

Comment #4 on issue 146 by honeycom...@gmail.com: JPEG image type checking

is too strict; EXIF is not interpreted as JPEG (itmf/type.cpp)
http://code.google.com/p/mp4v2/issues/detail?id=146

Oh, sorry. I thought you just need an EXIF image to reproduce/test the
issue.
Patching it is trivial.
Just change IMAGE_HEADERS[] array in itmf/type.cpp like the following:
- { BT_JPEG, "\xff\xd8\xff\xe0" },
+ { BT_JPEG, "\xff\xd8\xff" },

[mp...@googlecode.com]

Updates:
Status: Fixed

Comment #5 on issue 146 by kid...@gmail.com: JPEG image type checking is

too strict; EXIF is not interpreted as JPEG (itmf/type.cpp)
http://code.google.com/p/mp4v2/issues/detail?id=146

Fixed in r502--thanks.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings