Issue 26 in mp4v2: Size of sound atom should be 36 bytes instead of 34

[codesite...@google.com]

Comment #4 on issue 26 by ed...@myreflection.org: Size of sound atom should
be 36 bytes instead of 34
http://code.google.com/p/mp4v2/issues/detail?id=26

We can't just add an arbitrary 2 bytes without knowing where and what for.

Look at MP4SoundAtom::MP4SoundAtom() for how we construct the sound atom
for the different types. These are all based
on the QT specs
(http://www.monen.nl/DevDoc/documentation/QuickTime/QTFF/QTFFChap3/chapter_4_section_3.html)
for
a sound atom.

Note that there are two versions of the sound atom documented, but there is
also a version 2, not sure where that is
specified off hand.

AFAIK we are writing version 0 atoms by default.

void MP4SoundAtom::Generate()
{
...
((MP4Integer16Property*)m_pProperties[2])->SetValue(0);
...
}

I couldn't find anything special that is added for an alaw sound atom in
the spec (see the section for "IMA, uLaw, and aLaw") -
although it does sound as if it needs an extra property added, but I don't
want to add it without knowing for certain.
And if the problem is with all our Sound Atoms, then again I'd want to see
where we diverge from what is in the spec.

Cheers, Ed.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings