pending removal of MozMillAsyncTest

[Jeff Hammel]

We have something called MozMillAsyncTest in the Mozmill extension. See:

- https://bugzilla.mozilla.org/show_bug.cgi?id=637471
- https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/controller.js#L1296

As best I can tell, MozMillAsyncTest is unfinished and unused. Is
anyone using it out there? Would anyone object to its removal? If
anyone is using it, what are you using it for?

Jeff

[Mikeal Rogers]

I think the thunderbird team is using it, i added it for dmose a long long time ago.

[Jeff Hammel]

So what is its intention? Is it finished? Should we document this?

On Tue, Mar 1, 2011 at 12:02 PM, Mikeal Rogers <mikeal...@gmail.com> wrote:
> I think the thunderbird team is using it, i added it for dmose a long long
> time ago.
>

> --
> You received this message because you are subscribed to the Google Groups
> "MozMill Developers" group.
> To post to this group, send email to mozmi...@googlegroups.com.
> To unsubscribe from this group, send email to
> mozmill-dev...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/mozmill-dev?hl=en.
>

[Mikeal Rogers]

it's finished as in, it works.

should probably be documented, it has unit tests, or at least it did when i wrote it a few years ago.

[Jeff Hammel]

I was about to embark on the bug to unify control flow
(https://bugzilla.mozilla.org/show_bug.cgi?id=641615) which would make
all tests a class structure. I was trying to find an example of the
MozMillAsyncTest, to make sure I didn't break anything. However,
grepping through the entire comm-central repository, I can't find any.
Does anyone know where these are? Does anyone know if we actually
use them? As much as I'd like a more streamlined and class-based
class structure, I'd rather devote my energy to the other 139 mozmill
bugs if we're not using this.

[Mikeal Rogers]

check with the thunderbird team. i added it for dmose.

[Jeff Hammel]

So I checked with dmose + company and apparently they aren't used at
all. So we have two choices for mozmill-2.0:

A. Deprecating the MozMillAsyncTest stuff and reimplementing if
someone calls for it:
https://bugzilla.mozilla.org/show_bug.cgi?id=637471
B. Refactoring the existing tests to use a prototype based structure a
la MozMillAsyncTest so that we can unify code paths and not have
multiple places to maintain and further define what it is to be a
test: https://bugzilla.mozilla.org/show_bug.cgi?id=641615

While B. would be a nice-to-have, if you asked me if I wanted to do
this now, I would have to say "no, i'd rather clean up, move on, and
revisit". But other opinions welcome.

Jeff

On Mon, Mar 14, 2011 at 2:07 PM, Mikeal Rogers <mikeal...@gmail.com> wrote:
> check with the thunderbird team. i added it for dmose.
>

[Mikeal Rogers]

the sane thing seems to be to just cut it and if someone comes around going "where did that go!" you  implement B. no use writing all that code if nobody is using it.

[Jeff Hammel]

So we're slated to remove: https://bugzilla.mozilla.org/show_bug.cgi?id=637471

Thanks for the input!