would like to hide email addresses
Craig Dunigan
have been done before, it doesn't seem that unusual. I'm running
Bugzilla 3.0.2 for a non-profit, and the developers would prefer that
their email addresses not be displayed. In general, I'd prefer not to
display anyone's email address, just their chosen "full name," since
many users would prefer not to need to register to search bugs, and I
don't want anyone's email address to be publicly accessible. For now,
I have disallowed anonymous access, but that is inadequate for the
long term.
I can't locate a parameter to make this happen, so I'm assuming it's a
code change. I'm perfectly comfortable with Perl, so I'm just hoping
someone will save me the time of reading the code, and point me
towards the correct file(s) to modify, and give me a general idea of
what to change them to. Thanks in advance.
--
Craig Dunigan
IS Technical Services Specialist
Middleware - EIS - DoIT
University of Wisconsin, Madison
opinions expressed are my own, not the University's
Steve Wendt
> the developers would prefer that their email
> addresses not be displayed. In general, I'd prefer not to display
> anyone's email address, just their chosen "full name,"
There's a patch on Bugzilla that does the obvious bits; unfortunately it
seems to be down right now, so I can't point you to it.
Tosh, Michael J
'nick' is the email without the domain, in the rare case someone doesn't
have a fullname set. Here is a diff to use:
sub identity {
my $self = shift;
return "" unless $self->id;
if (!defined $self->{identity}) {
$self->{identity} =
- $self->name ? $self->name . " <" . $self->login. ">" :
$self->login;
+ $self->name ? $self->name : $self->nick;
}
return $self->{identity};
}
-----Original Message-----
From: support-bugz...@lists.mozilla.org
[mailto:support-bugz...@lists.mozilla.org] On Behalf Of Craig
Dunigan
Sent: Wednesday, February 13, 2008 3:28 PM
To: support-...@lists.mozilla.org
Subject: would like to hide email addresses
I've tried searching the archives, but came up empty. This has to
have been done before, it doesn't seem that unusual. I'm running
Bugzilla 3.0.2 for a non-profit, and the developers would prefer that
their email addresses not be displayed. In general, I'd prefer not to
display anyone's email address, just their chosen "full name," since
many users would prefer not to need to register to search bugs, and I
don't want anyone's email address to be publicly accessible. For now,
I have disallowed anonymous access, but that is inadequate for the
long term.
I can't locate a parameter to make this happen, so I'm assuming it's a
code change. I'm perfectly comfortable with Perl, so I'm just hoping
someone will save me the time of reading the code, and point me
towards the correct file(s) to modify, and give me a general idea of
what to change them to. Thanks in advance.
--
Craig Dunigan
IS Technical Services Specialist
Middleware - EIS - DoIT
University of Wisconsin, Madison
opinions expressed are my own, not the University's
_______________________________________________
support-bugzilla mailing list
support-...@lists.mozilla.org
https://lists.mozilla.org/listinfo/support-bugzilla
PLEASE put support-...@lists.mozilla.org in the To: field when you
reply.
Steve Wendt
>> the developers would prefer that their email addresses not be
>> displayed. In general, I'd prefer not to display anyone's email
>> address, just their chosen "full name,"
>
> There's a patch on Bugzilla that does the obvious bits;
Marc Schumann
Right, and further down the road, there's
https://bugzilla.mozilla.org/show_bug.cgi?id=218917.
Craig Dunigan
> 2008/2/13, Steve Wendt <spa...@forgetit.org>:
> Right, and further down the road, there's
> https://bugzilla.mozilla.org/show_bug.cgi?id=218917.
> _______________________________________________
> support-bugzilla mailing list
> support-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/support-bugzilla
> PLEASE put support-...@lists.mozilla.org in the To: field when you reply.
>
I see I should have checked Bugzilla's Bugzilla, instead of just the
mailing list archive. Thanks. The first patch looks like it'll be
just the right starting place for me. I'll try to locate the
"non-obvious bits" on my own.
Thanks again,
Craig Dunigan
thread got everything, so I started checking which scripts process
them, and whether there were other templates that used the variables
in question. After doing all that, it's become clear to me that this
is a much more complete and elegant solution. Actual code changes are
probably frowned upon for upgrade compatibility, but it's a
wonderfully clean approach. Now that I understand what it's doing, I
can probably manage making the same kind of change in any future
upgrades.
Thanks very much!
On Wed, 13 Feb 2008, Tosh, Michael J wrote:
> Take a look at "sub identity" within the Bugzilla/User.pm module.
> 'nick' is the email without the domain, in the rare case someone doesn't
> have a fullname set. Here is a diff to use:
>
> sub identity {
> my $self = shift;
>
> return "" unless $self->id;
>
> if (!defined $self->{identity}) {
> $self->{identity} =
> - $self->name ? $self->name . " <" . $self->login. ">" :
> $self->login;
> + $self->name ? $self->name : $self->nick;
> }
>
> return $self->{identity};
> }
>
>
>
>
> -----Original Message-----
> From: support-bugz...@lists.mozilla.org
> [mailto:support-bugz...@lists.mozilla.org] On Behalf Of Craig
> Dunigan
> Sent: Wednesday, February 13, 2008 3:28 PM
> To: support-...@lists.mozilla.org
> Subject: would like to hide email addresses
>
> I've tried searching the archives, but came up empty. This has to
> have been done before, it doesn't seem that unusual. I'm running
> Bugzilla 3.0.2 for a non-profit, and the developers would prefer that
> their email addresses not be displayed. In general, I'd prefer not to
Craig Dunigan
code tweak to Bugzilla::User actually handles about half the places
where an email address is displayed, so it didn't turn out to be as
clean as I'd hoped. The other half does require at least the template
tweaks noted in https://bugzilla.mozilla.org/show_bug.cgi?id=219021 ,
plus a few, and tiny bit more code change.
Since my issue was desiring to hide display of all email addresses
from all users, logged in or not, I also had to remove the "mailto:"
anchor tags in bug/create.html.tmpl and bug/edit.html.tmpl, and of
course not bother with the [% IF user.login %] bits in the patch noted
above. Naturally I had to the equivalent with the User.pm code tweaks
listed below. The new code change was to buglist.cgi, in the section
where display columns are defined. I had to change each of
DefineColumn("assigned_to", "map_assigned_to.login_name", Assignee");
DefineColumn("reporter", "map_reporter.login_name", "Reporter");
DefineColumn("qa_contact", "map_qa_contact.login_name", "QA Contact");
to "map_<whatever the column name is>_.realname", and comment out the
entire " if ($format->{'extension'} eq 'html') " block.
As long as you don't allow normal users to see the user list, and as
far as I can tell so far, that gets all the places the email address
is displayed, but one. That one is the display of the user's own
email address in the "logout" links, which is harmless.
I may go so far as to allow a privileged group to see the email
addresses, but that looks like it could get complex. Anyway, it looks
like I've gotten my concerns resolved. Thanks for all the help.
> _______________________________________________
> support-bugzilla mailing list
> support-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/support-bugzilla
> PLEASE put support-...@lists.mozilla.org in the To: field when you reply.
>
--
Steve Wendt
> Since my issue was desiring to hide display of all email addresses from
> all users, logged in or not,
That seems overly obsessive - did you really have users worried about
other logged in users seeing their email addresses?
Craig Dunigan
Actually, yes. It's a very loosely organized hobby project with
little to no accountability, so misbehaving would be both easy and
probably undetected. Some of the people in the community are very
concerned about preserving anonymity, and others couldn't care less.
I have developers who hesitate to accept bugs because regular users
could see their email addresses, and regular users who refuse to
register an account because they'd have to provide an email address.
The latter are clamoring for anonymous access, which, given the
former, I was unwilling to provide until I could protect the
developers' emails. FWIW, my own email address is prominently
displayed on the home page as the admin for Bugzilla. Even though I'm
in the unconcerned camp, I don't want to alienate anyone. So I did
the obsessive thing for them. :)
Sandeep A.S
While creating a product , there is a option to create a chart
database. I thought of doing it later point of time.
Now when I tried to edit/update that product for chart database,
creating chart database option is not available.
How can I create a chart database at later point of time?
Thanks
Sandeep
David Miller
> Just noting this so it will appear in mail archive searches. This
> code tweak to Bugzilla::User actually handles about half the places
> where an email address is displayed, so it didn't turn out to be as
> clean as I'd hoped. The other half does require at least the template
> tweaks noted in https://bugzilla.mozilla.org/show_bug.cgi?id=219021 ,
> plus a few, and tiny bit more code change.
It would be great if you could get the updated patch for this added to
one of those two bugs, too. Lots of people have been clamoring for
that, more for spam protection than trying to protect people from each
other. It's just a semi-complicated thing to pull off with Bugzilla's
current architecture, as you noted.
The other part of the problem of course comes to adding people to the CC
list, assignees, etc. If you can't use their email address, how do you
identify them? Bugzilla doesn't really have a unique user identifier
other than the email address currently, and if you did add one, how
would you create IDs for existing users that may or may not log in to
see a prompt asking they create an ID?
--
Dave Miller http://www.justdave.net/
System Administrator, Mozilla Corporation http://www.mozilla.com/
Project Leader, Bugzilla Bug Tracking System http://www.bugzilla.org/
Craig Dunigan
> Craig Dunigan wrote on 2/20/08 12:48 PM:
>> Just noting this so it will appear in mail archive searches. This
>> code tweak to Bugzilla::User actually handles about half the places
>> where an email address is displayed, so it didn't turn out to be as
>> clean as I'd hoped. The other half does require at least the template
>> tweaks noted in https://bugzilla.mozilla.org/show_bug.cgi?id=219021 ,
>> plus a few, and tiny bit more code change.
>
> It would be great if you could get the updated patch for this added to
> one of those two bugs, too. Lots of people have been clamoring for
> that, more for spam protection than trying to protect people from each
> other. It's just a semi-complicated thing to pull off with Bugzilla's
> current architecture, as you noted.
>
> The other part of the problem of course comes to adding people to the CC
> list, assignees, etc. If you can't use their email address, how do you
> identify them? Bugzilla doesn't really have a unique user identifier
> other than the email address currently, and if you did add one, how
> would you create IDs for existing users that may or may not log in to
> see a prompt asking they create an ID?
>
>
Heh. I just realized the bit about the CC list myself. I'm working
on it. Do you want the patch for "no email display" before or after I
get the CC thing worked out?
Craig Dunigan
> On Sat, 8 Mar 2008, David Miller wrote:
>
>> Craig Dunigan wrote on 2/20/08 12:48 PM:
>>> Just noting this so it will appear in mail archive searches. This
>>> code tweak to Bugzilla::User actually handles about half the places
>>> where an email address is displayed, so it didn't turn out to be as
>>> clean as I'd hoped. The other half does require at least the template
>>> tweaks noted in https://bugzilla.mozilla.org/show_bug.cgi?id=219021 ,
>>> plus a few, and tiny bit more code change.
>>
>> It would be great if you could get the updated patch for this added to
>> one of those two bugs, too. Lots of people have been clamoring for
>> that, more for spam protection than trying to protect people from each
>> other. It's just a semi-complicated thing to pull off with Bugzilla's
>> current architecture, as you noted.
>>
>> The other part of the problem of course comes to adding people to the CC
>> list, assignees, etc. If you can't use their email address, how do you
>> identify them? Bugzilla doesn't really have a unique user identifier
>> other than the email address currently, and if you did add one, how
>> would you create IDs for existing users that may or may not log in to
>> see a prompt asking they create an ID?
>>
>>
>
> Heh. I just realized the bit about the CC list myself. I'm working
> on it. Do you want the patch for "no email display" before or after I
> get the CC thing worked out?
>
>
Re-reading that, I realized that my brevity engendered obscurity. ;)
In my haste, I didn't actually address the issue you mention at all.
I meant that I intend to work out how to suppress display of addresses
on the CC list, which the changes I mention previously do not cover,
not that I intend to work out how to create a new unique user
identifier that can be used for assigning bugs. It looks like
https://bugzilla.mozilla.org/show_bug.cgi?id=218917 starts to address
that issue. My intention for my own situation is to allow only the
developer group to assign bugs, and allow that group to see all
addresses with the drop-down list option in the assign and CC fields.
Default assignee for components that don't currently have a real
default assignee will be a joint list address that goes to all
developers, probably with a "real name" that looks something like "Not
Assigned."
For the "official" patch, would it be beneficial for me to code it so
that I replace "developer group" with "logged in user," and make the
display suppression also dependent on login status? Is that what most
people actually want?
David Miller
That might be a good start. For open systems like Mozilla's Bugzilla
where anyone can create an account, we probably want it more restrictive
than that though. We have a few hundred thousand users, and it's well
worth a spammer's time to register for an account to be able to mine
that many addresses. In our case, limiting it to users with "editbugs"
privs would probably work well. We hand out editbugs fairly freely, but
generally they need to be active users that are actually working on
things. So probably the best way to do it is allow a configurable group
to be able to see such info (and we would set that to editbugs on
b.m.o). People who want it generally available could leave that group
blank (or create a group with a .* regexp and use that).
Craig Dunigan
> Craig Dunigan wrote on 3/10/08 10:39 AM:
>> On Mon, 10 Mar 2008, Craig Dunigan wrote:
>> For the "official" patch, would it be beneficial for me to code it so
>> that I replace "developer group" with "logged in user," and make the
>> display suppression also dependent on login status? Is that what most
>> people actually want?
>
> That might be a good start. For open systems like Mozilla's Bugzilla
> where anyone can create an account, we probably want it more restrictive
> than that though. We have a few hundred thousand users, and it's well
> worth a spammer's time to register for an account to be able to mine
> that many addresses. In our case, limiting it to users with "editbugs"
> privs would probably work well. We hand out editbugs fairly freely, but
> generally they need to be active users that are actually working on
> things. So probably the best way to do it is allow a configurable group
> to be able to see such info (and we would set that to editbugs on
> b.m.o). People who want it generally available could leave that group
> blank (or create a group with a .* regexp and use that).
>
>
Finally got the patch finished and attached to
https://bugzilla.mozilla.org/show_bug.cgi?id=219021 . I hope someone
finds it useful. I wrote it so that Bugzilla checks for membership in
a trusted group for email display, and not that it checks for login
status. It should be pretty simple to modify to login status if
that's what you prefer.