On 2012-04-06 11:33 PM, Robert O'Callahan wrote:
> On Sat, Apr 7, 2012 at 2:01 PM, Zack Weinberg<
za...@panix.com>
> wrote:
>
>> I would like to see some language [in the CoC] addressing
>> interactions between people who are more central to the community
>> and people who are more peripheral; especially, people who consider
>> themselves part of the community and people who don't. It has been
>> my experience that many people are scared to get involved because
>> they expect to be treated badly by established contributors (see
>> earlier message re bug reporting specifically). It has also been
>> my experience that a small number of senior contributors regularly
>> abuse other contributors and get away with it.
>
> Something needs to be done about this.
I assume your 'this' is the 'small number of senior contributors...'
sentence, and on reflection, I overstated the problem there.
What I should have said is, there are a small number of senior
contributors whose somewhat combative tone (in reviews, in discussion in
bugs, etc) we (regular contributors) are all accustomed to, so it seems
like no big deal _to us_, but if that's the first impression someone has
of how we do things, it can be extraordinarily off-putting. This
sometimes also comes up when a regular contributor in one area crosses
over into another area whose group dynamic is different.
I don't want to name names because I see this as a group-culture
problem, not a problem of specific people. Some people are (IMO)
over-aggressive all the time, but lots more people do it sometimes.
_I_ have probably done it to someone without realizing.
Partly I think it comes from a quite justified fear of letting our
standards slip, especially among the contributors who remember the bad
old days (I am still sort of wondering what the San Diego People did
that was so horrible that Shaver made jokes about it years later...)
And while it's possible to have high standards for the _code_ without
crushing egos all around, it's certainly more work for the reviewer, so
that feeds into the perennial lack-of-reviewer-hours problem.
The explicit mentoring process that we've added recently should help, I
think. Other things that occur that might help:
* (more) people whose official job is to talk to bug reporters
(in bugzilla, not just in the support forums)
* mentoring of the process of code reviewing
* finding ways to take load off overloaded reviewers
* written guidelines for how to criticize assertively but not
aggressively -- this *is* a skill that can be trained
> Do these people know who they are? (One of my greatest fears is that
> I will be abusive and not even realize it.)
For the record, you're one of the people who is _least_ likely to do
this, in my experience.
I recall someone else bringing up your quip about throwing people off a
bridge if they tried to port Gecko to a non-twos-complement machine (or
something like that) -- this _could have_ been problematic, but (not
having been there) probably wasn't, in context. It's aimed at a
hypothetical person who almost certainly doesn't exist (as far as I know
nobody's manufactured a non-twos-complement CPU in many years), it is a
standard kind of hyperbole, and it was on IRC. I'd hesitate to post
such a thing in bugzilla, it would be inappropriate in response to an
actual offer to port to a wacky machine, and ironically if you had
merely threatened to punch the hypothetical person, rather than
murdering them, it would be more problematic (because it'd be way more
plausible that you weren't joking in that case).
(In response to an actual offer to port I would probably say something
like "That would be a great deal of work, and we'd want you to do extra
work to keep the changes self-contained rather than being visible
throughout the code, and we're not promising that future changes won't
break it again, but if you really want to do it, go ahead.")
>> I don't think it's possible to overstate how easy it is for users
>> to write us off as *completely* *uninterested* in hearing about
>> their problems. As such, just about *any* policy change that makes
>> us seem less uninterested is worth doing IMHO.
>
> This is a tough one. A lot of these "cranky comments" are abusive.
> Letting them proliferate with impunity itself creates a hostile
> environment. I can shrug off invective claiming I'm an evil
> conspirator for not supporting MNG or SVG Fonts whatever; I don't
> want to ask that of all our contributors. So I don't know what to
> do. What do you think we should do?
Be very firm about _abuse_ of _people_, but allow _venting_ (which may
include put-downs of the _project_). Let's be concrete: here are some
examples from infamous bug 98168:
comment #108
| In February of last year I submitted to comment about this bug -
| disappointed that a seven year old bug had turned into a ridiculous
| idealogical debate instead of a real-world issue deserving of a fix.
comment #116
| I feel disappointed. Sorry, this is not something to help solve
| the bug, obviously you know how to fix it, the problem is that
| you don't want it.
These are venting, which should be tolerated -- i.e. should _not_ draw
responses of the form 'bugzilla etiquette forbids this sort of comment'.
The appropriate response to venting is no response at all.
comment #70
| This again is total ****. If the W3C spec says that it is allowed
| then your XSLT processor should allow it. If you can't do it, it
| just proes what second-rate programmers you are.
This is (just barely) abuse, because of the "what second-rate
programmers you are" line. (I deliberately picked something mild but
nonetheless IMHO unacceptable.) Abuse _should_ receive a polite but
firm rebuke, in this case I'd write "We understand that you are unhappy
about this bug, but we will not swallow insults over it. Please refrain
from calling people second-rate in the future." Note that the rebuke
that's actually in the bug is *not* a good example:
comment #71
| Tony, if you don't mind your wording in the future, we'll consider
| administrative actions against it.
It escalates too fast and is too blunt. This would be an appropriate
level of response to a significantly nastier comment.
Also, *ideally*, rebukes would go in a private email and the offending
comment would be marked hidden-by-default, but AFAIK we can't do that
right now.
zw