RFC: Tbpl with server-integration
Arpad Borsos
that would be possible when replacing the pushlog and tinderbox
parsers by a specialized server providing JSON data.
See the current prototype at: http://tbpl.swatinem.de/
Some of the major features include:
- switching between branches for Trees that are pulling from multiple
branches, such as SeaMonkey
- "unlimited scrollback": just scroll down and it dynamically loads
additional history
- tree status, including sheriff info and a % GREEN display.
- incremental updates
There is still "not yet supported" written all over it and the server-
side data is not refreshed periodically, lacks information about
results and notes.
I've just written a dumb php-script that parses the pushlog and
tinderbox json, writing data into a mysql database. The script
frequently fails due to OOM or sql exceptions and is definitely not
the way forward.
Using data from the official builddb (http://build.mozilla.org/
builds/) would be the way forward.
Something that would be really beneficial is accurate information for
in-progress builds. Those aren't displayed yet in my demo because they
have no revisions associated with them.
I've talked to catlee/ted about that. It would be nice to have the
TinderboxPrint data sent to some webservice collecting in-progress
data. Or a process similar how talos results are sent to the graph-
server. I must say I do not yet know how that process works, so if
anyone would like to enlighten me ;)
Comments much appreciated.
Mark Banner
> The last weeks I have been hacking away at some ideas I had about tbpl
> that would be possible when replacing the pushlog and tinderbox
> parsers by a specialized server providing JSON data.
So is this the intended way forward? If this is developed enough will it
replacing tinderbox? I know there's been various discussions/options for
moving forward, but afaict no-one's written down the proposed routes or
got a clear spec on where we want to go with tinderbox.
> See the current prototype at: http://tbpl.swatinem.de/
It looks nice.
> Some of the major features include:
> - switching between branches for Trees that are pulling from multiple
> branches, such as SeaMonkey
That's nice. Though I'm not sure "branch" is the right term here. Maybe
repository would be better.
> - "unlimited scrollback": just scroll down and it dynamically loads
> additional history
Though presumably that's limited by what's in the json files?
> - tree status, including sheriff info and a % GREEN display.
How is (or will) the tree status provided / generated? My biggest issue
with the way tinderbox works is that it doesn't support our needs:
- We're controlling tree status via a specific set of elements and text.
- hg hooks have to parse tinderbox output to get the status
- You've got no option to control multiple trees at once, i.e. if
there's a buildbot failure (or downtime) you've got to close at least 2,
if not more pages by going into each one in turn, and that's just sad.
I'm also concerned that in your mock-up that there's not much room for
additional tree links/information that tinderbox currently have. I don't
know how much people use these, but I certainly use and keep the
Thunderbird ones up to date, and explicitly point people at them so they
know where to look.
However, maybe we could have a panel that would provide a similar function?
> Comments much appreciated.
Some other random comments then, if you've just not implemented them
yet, that's fine:
1) On the tooltip for completed builds, include the time taken for
completion
2) When showing uncompleted builds, include the time taken so far, and
the estimated time.
=> if the estimated time is wrong, then at least someone can formulate
an idea can be obtained from the time taken of previous builds minus the
time taken so far.
3) Need to have specific builder names printed/displayed.
=> This could be your hooking up to TindeboxPrint output, but I don't
think so. What I'm really looking at here is that sometimes we do get
issues with specific builders (maybe more so on Thunderbird trees) -
they are far more identifiable on tinderbox because we have the builder
names there. Tbpl doesn't give you this information.
4) Once you get multiple projects and all their branches (3.0, 3.5, 3.6
etc) listed, you're going to have an issue with width, so you may need
to do something else for tree, maybe a Project drop-down, and then have
the branches listed for that project (after renaming the current
"branch"es to repositories).
5) There's no quick-status indication for other tree/branches. This is
sometimes useful just to gauge if a problem is likely to originate on a
different branch. Although I could live without this, as long as we
updated tinderstatus to work with the json data.
Standard8
Robert Kaiser
> See the current prototype at: http://tbpl.swatinem.de/
Doesn't even load here, just like most tbpl stuff. Not sure why, this is
a pretty normal SeaMonkey 2.0.x build.
Robert Kaiser
Boris Zbarsky
> Doesn't even load here, just like most tbpl stuff. Not sure why, this is
> a pretty normal SeaMonkey 2.0.x build.
Does 2.0.x use a Gecko that has cross-site XHR support?
-Boris
Markus Stange
does http://tests.themasta.com/tinderboxpushlog/ load for you now?
-Markus
Robert Kaiser
> I've just fixed https://bugzilla.mozilla.org/show_bug.cgi?id=545833 -
> does http://tests.themasta.com/tinderboxpushlog/ load for you now?
Yes, it does. Of course, it doesn't support the trees I'm usually
interested in (SeaMonkey, SeaMonkey2.0), but even having it load is
already good progress. Not that I prefer its display over a conventional
waterfall, but that's probably up to taste. ;-)
Robert Kaiser
Robert Kaiser
Gecko 1.9.1 should have that, right?
Robert Kaiser
Markus Stange
> Markus Stange wrote:
>> I've just fixed https://bugzilla.mozilla.org/show_bug.cgi?id=545833 -
>> does http://tests.themasta.com/tinderboxpushlog/ load for you now?
>
> Yes, it does.
Good.
> Of course, it doesn't support the trees I'm usually
> interested in (SeaMonkey, SeaMonkey2.0),
Gozer has created his own tbpl fork for comm-central trees:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=SeaMonkey
-Markus
Robert Kaiser
Ah, right, I heard there was one, but as I couldn't use either, I forgot
about that again, I guess. Also, as I said, it's not really doing a
representation I personally really like dealing with. I still like the
waterfall displays better.
Robert Kaiser