Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

landed some "Get"-removing renames

10 views
Skip to first unread message

L. David Baron

unread,
Feb 16, 2013, 4:56:37 PM2/16/13
to dev-tec...@lists.mozilla.org
I've landed some patches that remove "Get" from some commonly used
methods that never return null, following our convention that such
methods have "Get" in the name if and only if they sometimes return
null:

https://bugzilla.mozilla.org/show_bug.cgi?id=781360
https://bugzilla.mozilla.org/show_bug.cgi?id=841789

The most likely to bitrot patches is the change of the GetStyle*()
functions on nsIFrame and nsStyleContext for getting style structs.

It should be straightforward to fix up an existing patch queue using
the sed command in:
https://bugzilla.mozilla.org/show_bug.cgi?id=781360#c8
(all on one line), e.g., using the command:
sed -i -f <file-with-sed-command> <files-to-fix>
but be sure to back up your patch queue before doing such things.

-David

--
𝄞 L. David Baron http://dbaron.org/ 𝄂
𝄢 Mozilla http://www.mozilla.org/ 𝄂
0 new messages