Received: by 10.180.75.8 with SMTP id y8mr675500wiv.4.1343971367360;
        Thu, 02 Aug 2012 22:22:47 -0700 (PDT)
Received: by 10.224.100.137 with SMTP id y9mr263193qan.2.1343971367199;
        Thu, 02 Aug 2012 22:22:47 -0700 (PDT)
Path: n2ni13881454win.0!nntp.google.com!r1no1761163qas.0!news-out.google.com!c6ni7039921qas.0!nntp.google.com!Xl.tags.giganews.com!border1.nntp.dca.giganews.com!nntp.giganews.com!local2.nntp.dca.giganews.com!nntp.mozilla.org!news.mozilla.org.POSTED!not-for-mail
NNTP-Posting-Date: Fri, 03 Aug 2012 00:22:46 -0500
Return-Path: <j...@mozilla.com>
X-Original-To: dev-tech-js-engine-intern...@lists.mozilla.org
Delivered-To: dev-tech-js-engine-intern...@lists.mozilla.org
X-Virus-Scanned: amavisd-new at mozilla.org
Received-SPF: none (mozilla.com: No applicable sender policy available)
	receiver=mailman2.mail.corp.phx1.mozilla.com; identity=mailfrom;
	envelope-from="j...@mozilla.com"; helo=smtp.mozilla.org;
	client-ip=10.20.77.61
Date: Thu, 02 Aug 2012 22:22:52 -0700
From: Jim Blandy <j...@mozilla.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:14.0) Gecko/20120717 Thunderbird/14.0
MIME-Version: 1.0
To: Benjamin Peterson <benja...@python.org>
References: <501AFDBC.7010400@mozilla.com>
	<CAPZV6o8NXSm-5jHam3G7Wc8_kzHhEvwnzAJtp6Ox=nsmX42jgA@mail.gmail.com>
In-Reply-To: <CAPZV6o8NXSm-5jHam3G7Wc8_kzHhEvwnzAJtp6Ox=nsmX42jgA@mail.gmail.com>
X-Enigmail-Version: 1.4.3
Cc: dev-tech-js-engine-intern...@lists.mozilla.org
X-BeenThere: dev-tech-js-engine-intern...@lists.mozilla.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SpiderMonkey internals
	<dev-tech-js-engine-internals.lists.mozilla.org>
List-Unsubscribe: <https://lists.mozilla.org/options/dev-tech-js-engine-internals>,
	<mailto:dev-tech-js-engine-internals-requ...@lists.mozilla.org?subject=unsubscribe>
List-Archive: <http://lists.mozilla.org/pipermail/dev-tech-js-engine-internals/>
List-Post: <mailto:dev-tech-js-engine-intern...@lists.mozilla.org>
List-Help: <mailto:dev-tech-js-engine-internals-requ...@lists.mozilla.org?subject=help>
List-Subscribe: <https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals>,
	<mailto:dev-tech-js-engine-internals-requ...@lists.mozilla.org?subject=subscribe>
subject: Re: Getting GDB Python extensions for SpiderMonkey debugging into
 the source tree
Newsgroups: mozilla.dev.tech.js-engine.internals
Message-ID: <mailman.15393.1343971366.27472.dev-tech-js-engine-intern...@lists.mozilla.org>
Lines: 15
X-Usenet-Provider: http://www.giganews.com
NNTP-Posting-Host: 63.245.216.66
X-AuthenticatedUsername: NoAuthUser
X-Trace: sv3-2K6d7cf764Pi8Up4plQjkX2yC6siYBTdNa3zI/Ex56JN/fg4O2T/wUmhU3fPEfp0lfNYMbb72PDfkXt!Vok0w9zO4ZCt0GVqsGpGf/+9C+7B3KWeQ3SRDp22s32i8JjQupRYZj5kzI9zAkNoG10yTp81bkTo!ccuKzhySsyKRaIfObdINAphf3PPep8EzdOTJydXIKvCDYEn5y3ckjTQM
X-Complaints-To: ab...@mozilla.org
X-DMCA-Complaints-To: ab...@mozilla.org
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
Bytes: 3637
X-Original-Bytes: 3576
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 08/02/2012 06:37 PM, Benjamin Peterson wrote:
> Can tests be written for them, such that engine changes that break
> debugging hooks will become immediately known? 
There are unit tests for the pretty-printers.

I'd suggest that those tests *not* be hooked up to 'make check' to run
by default, because they can't be run on OSX and Windows; developers on
those platforms could break them, not find out until they hit try, and
then be stuck updating debugging tools they don't even use.

I could add a configuration flag to add the GDB tests to 'make check',
so that developers could 'opt in' to getting trouble reports for the
pretty-printers. At least the way I work, I have scripts to run
configure for me in the ways I usually need, so this would be easy for
me to enable for all my builds.