superreview requested: [Bug 859817] Eliminate implicit conversion from raw pointer to already_AddRefed : [Attachment 735816] Patch

[bugzill...@mozilla.org]

:Aryeh Gregor <a...@aryeh.name> has asked Benjamin Smedberg [:bsmedberg]
<benj...@smedbergs.us> for superreview:
Bug 859817: Eliminate implicit conversion from raw pointer to already_AddRefed
https://bugzilla.mozilla.org/show_bug.cgi?id=859817

Attachment 735816: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=735816&action=edit


------- Additional Comments from :Aryeh Gregor <a...@aryeh.name>
Boris wanted me to request super-review from bsmedberg on the basic concept.

[bugzill...@mozilla.org]

Benjamin Smedberg [:bsmedberg] <benj...@smedbergs.us> has granted :Aryeh
Gregor <a...@aryeh.name>'s request for superreview:

[bugzill...@mozilla.org]

:Aryeh Gregor <a...@aryeh.name> has asked Benjamin Smedberg [:bsmedberg]

<benj...@smedbergs.us> for superreview:

Bug 859817: Eliminate implicit conversion from raw pointer to already_AddRefed
https://bugzilla.mozilla.org/show_bug.cgi?id=859817

Attachment 747028: Patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=747028&action=edit

------- Additional Comments from :Aryeh Gregor <a...@aryeh.name>

This is a new version of the patch that fixes comment 39. From looking at
online documentation, it seems all three major compilers supported decltype
before or at the same time as nullptr, so this should work on all compilers.
If it doesn't, I guess I could add a separate test for decltype to mfbt, but it
seems unlikely to get much use. This builds on all our try platforms (-b d -p
all).

[bugzill...@mozilla.org]

Benjamin Smedberg [:bsmedberg] <benj...@smedbergs.us> has granted :Aryeh

Gregor <a...@aryeh.name>'s request for superreview: