Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview requested: [Bug 862401] keyword search is broken for search engines using POST : [Attachment 738836] Make sure nsDefaultURIFixup::KeywordToURI propagates POST data

2 views
Skip to first unread message

bugzill...@mozilla.org

unread,
Apr 17, 2013, 8:57:18 PM4/17/13
to dev-supe...@lists.mozilla.org
Mike de Boer [:mikedeboer] <mde...@mozilla.com> has asked Boris Zbarsky (:bz)
<bzba...@mit.edu> for superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 738836: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data
https://bugzilla.mozilla.org/attachment.cgi?id=738836&action=edit

bugzill...@mozilla.org

unread,
Apr 17, 2013, 10:38:02 PM4/17/13
to dev-supe...@lists.mozilla.org
Boris Zbarsky (:bz) <bzba...@mit.edu> has granted Mike de Boer [:mikedeboer]
<mde...@mozilla.com>'s request for superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 738836: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data
https://bugzilla.mozilla.org/attachment.cgi?id=738836&action=edit


------- Additional Comments from Boris Zbarsky (:bz) <bzba...@mit.edu>
Should the new outparam be optional to avoid breaking existing JS consumers?

sr=me with that

bugzill...@mozilla.org

unread,
Apr 22, 2013, 8:41:35 AM4/22/13
to dev-supe...@lists.mozilla.org
Mike de Boer [:mikedeboer] <mde...@mozilla.com> has granted superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 740251: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data
https://bugzilla.mozilla.org/attachment.cgi?id=740251&action=edit


------- Additional Comments from Mike de Boer [:mikedeboer]
<mde...@mozilla.com>
aPostData now optional. Carrying over sr=bz, r=gavin.

bugzill...@mozilla.org

unread,
Apr 23, 2013, 6:50:24 AM4/23/13
to dev-supe...@lists.mozilla.org
Mike de Boer [:mikedeboer] <mde...@mozilla.com> has granted superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 740740: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data
https://bugzilla.mozilla.org/attachment.cgi?id=740740&action=edit


------- Additional Comments from Mike de Boer [:mikedeboer]
<mde...@mozilla.com>
thanks to tips from bz: aPostData now truly optional

bugzill...@mozilla.org

unread,
Apr 26, 2013, 10:14:29 AM4/26/13
to dev-supe...@lists.mozilla.org
Mike de Boer [:mikedeboer] <mde...@mozilla.com> has asked Boris Zbarsky (:bz)
<bzba...@mit.edu> for superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 742352: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data, take 2
https://bugzilla.mozilla.org/attachment.cgi?id=742352&action=edit

bugzill...@mozilla.org

unread,
Apr 29, 2013, 5:29:32 PM4/29/13
to dev-supe...@lists.mozilla.org
Boris Zbarsky (:bz) <bzba...@mit.edu> has not granted Mike de Boer
[:mikedeboer] <mde...@mozilla.com>'s request for superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 742352: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data, take 2
https://bugzilla.mozilla.org/attachment.cgi?id=742352&action=edit


------- Additional Comments from Boris Zbarsky (:bz) <bzba...@mit.edu>
>+ aPostStream = static_cast<nsIInputStream*>(postData);

Why is that ok? Seems like that will leave aPostStream dangling once postData
goes out of scope...

You probably want to have an on-stack nsCOMPtr that gets initialized to
aPostStream and changed here as needed and used elsewhere in this function.

bugzill...@mozilla.org

unread,
May 1, 2013, 7:06:49 AM5/1/13
to dev-supe...@lists.mozilla.org
Mike de Boer [:mikedeboer] <mde...@mozilla.com> has asked Boris Zbarsky (:bz)
<bzba...@mit.edu> for superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 744074: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data, take 2
https://bugzilla.mozilla.org/attachment.cgi?id=744074&action=edit


------- Additional Comments from Mike de Boer [:mikedeboer]
<mde...@mozilla.com>
Fixed issues as per bz's comments

bugzill...@mozilla.org

unread,
May 1, 2013, 11:18:07 AM5/1/13
to dev-supe...@lists.mozilla.org
Boris Zbarsky (:bz) <bzba...@mit.edu> has granted Mike de Boer [:mikedeboer]
<mde...@mozilla.com>'s request for superreview:
Bug 862401: keyword search is broken for search engines using POST
https://bugzilla.mozilla.org/show_bug.cgi?id=862401

Attachment 744074: Make sure nsDefaultURIFixup::KeywordToURI propagates POST
data, take 2
https://bugzilla.mozilla.org/attachment.cgi?id=744074&action=edit


------- Additional Comments from Boris Zbarsky (:bz) <bzba...@mit.edu>
sr=me
0 new messages