superreview requested: [Bug 822210] B2G CDMA: support call waiting : [Attachment 747903] Part 1 - idl change - add oncallwaiting event

[bugzill...@mozilla.org]

Hsin-Yi Tsai [:hsinyi] <ht...@mozilla.com> has asked Jonas Sicking (:sicking)
<jo...@sicking.cc> for superreview:
Bug 822210: B2G CDMA: support call waiting
https://bugzilla.mozilla.org/show_bug.cgi?id=822210

Attachment 747903: Part 1 - idl change - add oncallwaiting event
https://bugzilla.mozilla.org/attachment.cgi?id=747903&action=edit


------- Additional Comments from Hsin-Yi Tsai [:hsinyi] <ht...@mozilla.com>
Hi Jonas,

Per partner's request, we are going to support cdma feature.

Due to the very difference between gsm, we need to add one more callwaiting
event. Please see my comment #1 for details.

And even this event is just additional for gsm, I am thinking that we should
dispatch the event on both cdma and gsm networks, since I guess it's not a good
idea that we reveal something very specific to the hardware or protocol in
WebAPI level.

How do you think about this?

[bugzill...@mozilla.org]

Hsin-Yi Tsai [:hsinyi] <ht...@mozilla.com> has canceled Hsin-Yi Tsai [:hsinyi]
<ht...@mozilla.com>'s request for superreview:

Bug 822210: B2G CDMA: support call waiting
https://bugzilla.mozilla.org/show_bug.cgi?id=822210

Attachment 747903: Part 1 - idl change - add oncallwaiting event
https://bugzilla.mozilla.org/attachment.cgi?id=747903&action=edit


------- Additional Comments from Hsin-Yi Tsai [:hsinyi] <ht...@mozilla.com>

Cancelling the review request since I am thinking that we would have to come
out a thorough picture of how to handle cdma and gsm networks first.

[bugzill...@mozilla.org]

Hsin-Yi Tsai [:hsinyi] <ht...@mozilla.com> has asked Jonas Sicking (:sicking)

<jo...@sicking.cc> for superreview:

Bug 822210: B2G CDMA: support call waiting
https://bugzilla.mozilla.org/show_bug.cgi?id=822210

Attachment 747903: Part 1 - idl change - add oncallwaiting event
https://bugzilla.mozilla.org/attachment.cgi?id=747903&action=edit


------- Additional Comments from Hsin-Yi Tsai [:hsinyi] <ht...@mozilla.com>

Hi Jonas,

I am asking for review again. Please refer to comment #8 for more explanation.
Thanks :)

[bugzill...@mozilla.org]

Jonas Sicking (:sicking) <jo...@sicking.cc> has granted Hsin-Yi Tsai [:hsinyi]
<ht...@mozilla.com>'s request for superreview: