superreview requested: [Bug 872100] app.clearBrowserData appears to not clear browser data immediately : [Attachment 751066] patch

[bugzill...@mozilla.org]

Fabrice Desré [:fabrice] <fab...@mozilla.com> has asked Jonas Sicking
(:sicking) <jo...@sicking.cc> for superreview:
Bug 872100: app.clearBrowserData appears to not clear browser data immediately
https://bugzilla.mozilla.org/show_bug.cgi?id=872100

Attachment 751066: patch
https://bugzilla.mozilla.org/attachment.cgi?id=751066&action=edit


------- Additional Comments from Fabrice Desré [:fabrice] <fab...@mozilla.com>
Cleaned up patch, with both the mozApps API changes and the NeckoParent fix.

Jonas & Mounir, the API change is backward compatible with the current one: I
made clearBrowserData() return a DOMRequest instead of void to let the caller
be notified when we are actually done with clearing the data.

[bugzill...@mozilla.org]

Mounir Lamouri (:mounir) <mou...@lamouri.fr> has granted Fabrice Desré
[:fabrice] <fab...@mozilla.com>'s request for superreview:

Bug 872100: app.clearBrowserData appears to not clear browser data immediately
https://bugzilla.mozilla.org/show_bug.cgi?id=872100

Attachment 751066: patch
https://bugzilla.mozilla.org/attachment.cgi?id=751066&action=edit

------- Additional Comments from Mounir Lamouri (:mounir) <mou...@lamouri.fr>
Review of attachment 751066:
-----------------------------------------------------------------

sr=me with the comments addressed.

::: dom/apps/src/Webapps.js
@@ +508,1 @@
> }

else {
Services.DOMRequest.fireAsyncError(req, "FOO");
}

// or whatever the syntax is. You should not leave that DOMRequest with a
pending state for ever.

::: netwerk/ipc/NeckoParent.cpp
@@ +88,5 @@
> nsRefPtr<TabParent> tabParent = static_cast<TabParent*>(aBrowser);
>
> *aAppId = tabParent->OwnOrContainingAppId();
> + *aInBrowserElement = aSerialized.IsNotNull() ?
aSerialized.mIsInBrowserElement
> + :
tabParent->IsBrowserElement();

How is that related to this patch?