superreview requested: [Bug 855655] [AudioChannelManager] Add New Attribute for Setting Default Control Volume Channel per Window : [Attachment 752124] NewWebAPI - v1

[bugzill...@mozilla.org]

Marco Chen [:mchen] <mc...@mozilla.com> has asked Jonas Sicking (:sicking)
<jo...@sicking.cc> for superreview:
Bug 855655: [AudioChannelManager] Add New Attribute for Setting Default Control
Volume Channel per Window
https://bugzilla.mozilla.org/show_bug.cgi?id=855655

Attachment 752124: NewWebAPI - v1
https://bugzilla.mozilla.org/attachment.cgi?id=752124&action=edit


------- Additional Comments from Marco Chen [:mchen] <mc...@mozilla.com>
Hi Jonas,

This webidl added a new attribute called volumeControlChannel which is
introduced at link as below.

https://wiki.mozilla.org/WebAPI/AudioChannels

[bugzill...@mozilla.org]

Jonas Sicking (:sicking) <jo...@sicking.cc> has granted Marco Chen [:mchen]
<mc...@mozilla.com>'s request for superreview:

Bug 855655: [AudioChannelManager] Add New Attribute for Setting Default Control
Volume Channel per Window
https://bugzilla.mozilla.org/show_bug.cgi?id=855655

Attachment 752124: NewWebAPI - v1
https://bugzilla.mozilla.org/attachment.cgi?id=752124&action=edit

------- Additional Comments from Jonas Sicking (:sicking) <jo...@sicking.cc>
Review of attachment 752124:
-----------------------------------------------------------------

I assume that the attribute is by default set to the empty string. Which would
mean "use platform default"?

If so, this looks good to me.

[bugzill...@mozilla.org]

Marco Chen [:mchen] <mc...@mozilla.com> has granted superreview:

Bug 855655: [AudioChannelManager] Add New Attribute for Setting Default Control
Volume Channel per Window
https://bugzilla.mozilla.org/show_bug.cgi?id=855655

Attachment 803646: NewWebAPI - v2
https://bugzilla.mozilla.org/attachment.cgi?id=803646&action=edit

------- Additional Comments from Marco Chen [:mchen] <mc...@mozilla.com>

Carry the super reviewer name.