Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

superreview requested: [Bug 863281] emergency call label not shown : [Attachment 743005] Add emergency property in TelephonyCall

2 views
Skip to first unread message

bugzill...@mozilla.org

unread,
Apr 29, 2013, 7:50:38 AM4/29/13
to dev-supe...@lists.mozilla.org
Szu-Yu Chen [:aknow] <szc...@mozilla.com> has asked Mounir Lamouri (:mounir)
<mou...@lamouri.fr> for superreview:
Bug 863281: emergency call label not shown
https://bugzilla.mozilla.org/show_bug.cgi?id=863281

Attachment 743005: Add emergency property in TelephonyCall
https://bugzilla.mozilla.org/attachment.cgi?id=743005&action=edit

bugzill...@mozilla.org

unread,
May 1, 2013, 3:38:37 PM5/1/13
to dev-supe...@lists.mozilla.org
Mounir Lamouri (:mounir) <mou...@lamouri.fr> has granted Szu-Yu Chen [:aknow]
<szc...@mozilla.com>'s request for superreview:
Bug 863281: emergency call label not shown
https://bugzilla.mozilla.org/show_bug.cgi?id=863281

Attachment 743005: Add emergency property in TelephonyCall
https://bugzilla.mozilla.org/attachment.cgi?id=743005&action=edit


------- Additional Comments from Mounir Lamouri (:mounir) <mou...@lamouri.fr>
Review of attachment 743005:
-----------------------------------------------------------------

::: dom/telephony/nsITelephonyProvider.idl
@@ +3,4 @@
> * You can obtain one at http://mozilla.org/MPL/2.0/. */
>
> #include "nsISupports.idl"
> +[scriptable, uuid(bde19ba2-83c8-4df7-a014-28fe71535527)]

nit: could you keep the empty line between the "#include" line and the
"[scriptable, ...]" one?

bugzill...@mozilla.org

unread,
May 9, 2013, 11:56:45 PM5/9/13
to dev-supe...@lists.mozilla.org
Szu-Yu Chen [:aknow] <szc...@mozilla.com> has asked Mounir Lamouri (:mounir)
<mou...@lamouri.fr> for superreview:
Bug 863281: B2G WebTelephony - expose emergency call info
https://bugzilla.mozilla.org/show_bug.cgi?id=863281

Attachment 747753: [PATCH 1/4 #4] Add emergency property in TelephonyCall.
https://bugzilla.mozilla.org/attachment.cgi?id=747753&action=edit

bugzill...@mozilla.org

unread,
May 10, 2013, 7:21:04 AM5/10/13
to dev-supe...@lists.mozilla.org
Mounir Lamouri (:mounir) <mou...@lamouri.fr> has granted Szu-Yu Chen [:aknow]
<szc...@mozilla.com>'s request for superreview:
0 new messages