superreview requested: [Bug 536285] Import Nitro assembler : [Attachment 424230] fix compilation warnings in previous patch
bugzill...@mozilla.org
<dsi...@mozilla.com> for superreview:
Bug 536285: Import Nitro assembler
https://bugzilla.mozilla.org/show_bug.cgi?id=536285
Attachment 424230: fix compilation warnings in previous patch
https://bugzilla.mozilla.org/attachment.cgi?id=424230&action=edit
bugzill...@mozilla.org
request for superreview:
Attachment 424230: fix compilation warnings in previous patch
https://bugzilla.mozilla.org/attachment.cgi?id=424230&action=edit
------- Additional Comments from Julian Seward <jse...@acm.org>
Ah, there has been some confusion and some small duplication of work.
I didn't realise you'd managed to actually get it to build on Windows.
Anyway, attached is a revised patch which builds and runs the TestMain
tests on {x86,amd64,arm}-linux, x86-win32 and x86-darwin. For x86-win32,
it just runs the two TestMain tests which don't require inline assembly,
but in any case those are the most interesting tests. I think this is
suitable now for reviewing.
bugzill...@mozilla.org
Attachment 425018: patch that builds on {x86,amd64,arm}-linux, x86-win32 and
x86-darwin
https://bugzilla.mozilla.org/attachment.cgi?id=425018&action=edit
bugzill...@mozilla.org
<jse...@acm.org>'s request for superreview:
Attachment 425018: patch that builds on {x86,amd64,arm}-linux, x86-win32 and
x86-darwin
https://bugzilla.mozilla.org/attachment.cgi?id=425018&action=edit
------- Additional Comments from Damon Sicore (:damons) <dsi...@mozilla.com>
Do we need to add an entry in about:license for these files? Seems we do.
Reviewed with legal. I think the about:license issue is our only concern. If
we do need to add a reference, Sayre, can you file a bug, please?
sr+=damons